Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26f20260 authored by Pawin Vongmasa's avatar Pawin Vongmasa
Browse files

Add a missing check for HIDL transaction status. 

Test: CtsMediaTestCases
Bug: 31399200
Change-Id: I515b0b0bf0eee44a7ec664fdd48d0a7bef68d323
parent ad13f70f

media/libstagefright/omx/hal/1.0/impl/WOmxObserver.cpp

+5 −1
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 
 * limitations under the License.

 */



#define LOG_TAG "WOmxObserver-impl"

#include "WOmxObserver.h"



#include <vector>
@@ -43,7 +44,10 @@ void LWOmxObserver::onMessages(std::list<omx_message> const& lMessages) { 
        wrapAs(&tMessages[i], &handles[i], message);

        ++i;

    }

    mBase->onMessages(tMessages);

    auto transResult = mBase->onMessages(tMessages);

    if (!transResult.isOk()) {

        ALOGE("LWOmxObserver::onMessages transaction failed");

    }

    for (auto& handle : handles) {

        native_handle_close(handle);

        native_handle_delete(handle);

media/libstagefright/omx/hal/1.0/utils/WOmxObserver.cpp

+5 −1
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 
 * limitations under the License.

 */



#define LOG_TAG "WOmxObserver-utils"

#include "WOmxObserver.h"



#include <vector>
@@ -43,7 +44,10 @@ void LWOmxObserver::onMessages(std::list<omx_message> const& lMessages) { 
        wrapAs(&tMessages[i], &handles[i], message);

        ++i;

    }

    mBase->onMessages(tMessages);

    auto transResult = mBase->onMessages(tMessages);

    if (!transResult.isOk()) {

        ALOGE("LWOmxObserver::onMessages transaction failed");

    }

    for (auto& handle : handles) {

        native_handle_close(handle);

        native_handle_delete(handle);