Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24ba9218 authored by Linus Nilsson's avatar Linus Nilsson
Browse files

Transcoder: Relax the bitrate file size thresholds for cuttlefish 

Bug: 174678558
Test: Ran transcoder unit test
Change-Id: I72ae7f6f26fb984ee81e1003e782d4decc538275
parent f674100b

media/libmediatranscoding/transcoder/tests/MediaTranscoderTests.cpp

+6 −4
Original line number Diff line number Diff line
@@ -326,8 +326,9 @@ TEST_F(MediaTranscoderTests, TestPreserveBitrate) { 
    const char* destPath = "/data/local/tmp/MediaTranscoder_PreserveBitrate.MP4";

    testTranscodeVideo(srcPath, destPath, AMEDIA_MIMETYPE_VIDEO_AVC);



    // Require maximum of 10% difference in file size.

    EXPECT_LT(getFileSizeDiffPercent(srcPath, destPath, true /* absolute*/), 10);

    // Require maximum of 25% difference in file size.

    // TODO(b/174678336): Find a better test asset to tighten the threshold.

    EXPECT_LT(getFileSizeDiffPercent(srcPath, destPath, true /* absolute*/), 25);

}



TEST_F(MediaTranscoderTests, TestCustomBitrate) {
@@ -339,8 +340,9 @@ TEST_F(MediaTranscoderTests, TestCustomBitrate) { 
    testTranscodeVideo(srcPath, destPath2, AMEDIA_MIMETYPE_VIDEO_AVC, 8 * 1000 * 1000);



    // The source asset is very short and heavily compressed from the beginning so don't expect the

    // requested bitrate to be exactly matched. However 40% difference seems reasonable.

    EXPECT_GT(getFileSizeDiffPercent(destPath1, destPath2), 40);

    // requested bitrate to be exactly matched. However the 8mbps should at least be larger.

    // TODO(b/174678336): Find a better test asset to tighten the threshold.

    EXPECT_GT(getFileSizeDiffPercent(destPath1, destPath2), 10);

}



static AMediaFormat* getAVCVideoFormat(AMediaFormat* sourceFormat) {