Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2428c6b9 authored by Eric Laurent's avatar Eric Laurent
Browse files

audio policy: different default config for system volumes 

When a volume curve is not found for a volume group
associated to a system strategy, use AUDIO_STREAM_PATCH
instead of AUDIO_STREAM_MUSIC as default config.

Bug:148588565
Test: play music and check volume
Change-Id: Ib3fb2a1b7b5f3118bf16a3cc9d8e578fa0431645
Merged-In: Ib3fb2a1b7b5f3118bf16a3cc9d8e578fa0431645
parent de82404c

services/audiopolicy/engine/common/src/EngineBase.cpp

+12 −2
Original line number Diff line number Diff line
@@ -171,11 +171,15 @@ engineConfig::ParsingResult EngineBase::loadAudioPolicyEngineConfig() 
    ALOGE_IF(result.nbSkippedElement != 0, "skipped %zu elements", result.nbSkippedElement);



    engineConfig::VolumeGroup defaultVolumeConfig;

    engineConfig::VolumeGroup defaultSystemVolumeConfig;

    for (auto &volumeConfig : result.parsedConfig->volumeGroups) {

        // save default volume config for streams not defined in configuration

        if (volumeConfig.name.compare("AUDIO_STREAM_MUSIC") == 0) {

            defaultVolumeConfig = volumeConfig;

        }

        if (volumeConfig.name.compare("AUDIO_STREAM_PATCH") == 0) {

            defaultSystemVolumeConfig = volumeConfig;

        }

        loadVolumeConfig(mVolumeGroups, volumeConfig);

    }

    for (auto& strategyConfig : result.parsedConfig->productStrategies) {
@@ -188,10 +192,16 @@ engineConfig::ParsingResult EngineBase::loadAudioPolicyEngineConfig() 
            // If no volume group provided for this strategy, creates a new one using

            // Music Volume Group configuration (considered as the default)

            if (iter == end(mVolumeGroups)) {

                engineConfig::VolumeGroup volumeConfig;

                if (group.stream >= AUDIO_STREAM_PUBLIC_CNT) {

                    volumeConfig = defaultSystemVolumeConfig;

                } else {

                    volumeConfig = defaultVolumeConfig;

                }

                ALOGW("%s: No configuration of %s found, using default volume configuration"

                        , __FUNCTION__, group.volumeGroup.c_str());

                defaultVolumeConfig.name = group.volumeGroup;

                volumeGroup = loadVolumeConfig(mVolumeGroups, defaultVolumeConfig);

                volumeConfig.name = group.volumeGroup;

                volumeGroup = loadVolumeConfig(mVolumeGroups, volumeConfig);

            } else {

                volumeGroup = iter->second;

            }