Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2173dd89 authored by Jeremy Wu's avatar Jeremy Wu
Browse files

APS: fix ALOGV crash in `doOnCheckSpatializer` 

When the log level is enabled, this can crash due to
the null check coming after reading its value.

Bug: 425603904
Test: m
Flag: EXEMPT trivial bug fix
Change-Id: Id2dda63e136e8583d85f28dc508104628d1ed010
parent c9337298

services/audiopolicy/service/AudioPolicyService.cpp

+5 −3
Original line number Diff line number Diff line
@@ -602,12 +602,14 @@ void AudioPolicyService::maybeCheckSpatializer_l() { 


void AudioPolicyService::doOnCheckSpatializer()

{

    ALOGV("%s mSpatializer %p level %d",

        __func__, mSpatializer.get(), (int)mSpatializer->getLevel());



    if (mSpatializer == nullptr) {

        ALOGV("%s mSpatializer == null", __func__);

        return;

    }



    ALOGV("%s mSpatializer %p level %d",

        __func__, mSpatializer.get(), (int)mSpatializer->getLevel());



    // Note: mSpatializer != nullptr =>  mAudioPolicyManager != nullptr

    if (mSpatializer->getLevel() != Spatialization::Level::NONE) {

        audio_io_handle_t currentOutput = mSpatializer->getOutput();