Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 209bbbcf authored by Jean-Michel Trivi's avatar Jean-Michel Trivi
Browse files

Apply EQ and bass boost first in effect chain 

EQ and bass boost can improperly interact with other effects
 (e.g. virtualizer) outside of the bundle. Apply them first
 in an effect chain, which is equivalent to using them to affect
 the content of a track, rather than how a track is presented,
 when additional effects are cascaded behind EQ and BB.

Bug 8589316

Change-Id: Ifb34e46bc1969f613cdc90ee2a79af677e2fad92
parent e6478de7

media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp

+2 −2
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ const effect_descriptor_t gBassBoostDescriptor = { 
        {0x0634f220, 0xddd4, 0x11db, 0xa0fc, { 0x00, 0x02, 0xa5, 0xd5, 0xc5, 0x1b }},

        {0x8631f300, 0x72e2, 0x11df, 0xb57e, {0x00, 0x02, 0xa5, 0xd5, 0xc5, 0x1b}}, // uuid

        EFFECT_CONTROL_API_VERSION,

        (EFFECT_FLAG_TYPE_INSERT | EFFECT_FLAG_INSERT_LAST | EFFECT_FLAG_DEVICE_IND

        (EFFECT_FLAG_TYPE_INSERT | EFFECT_FLAG_INSERT_FIRST | EFFECT_FLAG_DEVICE_IND

        | EFFECT_FLAG_VOLUME_CTRL),

        BASS_BOOST_CUP_LOAD_ARM9E,

        BUNDLE_MEM_USAGE,
@@ -108,7 +108,7 @@ const effect_descriptor_t gEqualizerDescriptor = { 
        {0x0bed4300, 0xddd6, 0x11db, 0x8f34, {0x00, 0x02, 0xa5, 0xd5, 0xc5, 0x1b}}, // type

        {0xce772f20, 0x847d, 0x11df, 0xbb17, {0x00, 0x02, 0xa5, 0xd5, 0xc5, 0x1b}}, // uuid Eq NXP

        EFFECT_CONTROL_API_VERSION,

        (EFFECT_FLAG_TYPE_INSERT | EFFECT_FLAG_INSERT_LAST | EFFECT_FLAG_VOLUME_CTRL),

        (EFFECT_FLAG_TYPE_INSERT | EFFECT_FLAG_INSERT_FIRST | EFFECT_FLAG_VOLUME_CTRL),

        EQUALIZER_CUP_LOAD_ARM9E,

        BUNDLE_MEM_USAGE,

        "Equalizer",