Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b9f9b13 authored by Eric Laurent's avatar Eric Laurent
Browse files

audioflinger: fix offload resume after drain 

When pausing and resuming during the drain,
the drain sequence number shuold not be modified
otherwise the drain callback will be ignored.
This causes failure to notify end of stream to audio
player and transition to next song.

Bug: 11247103.
Change-Id: I2a35c5cc3fd6aa667cdd257f9e9cc8715cef5159
parent 22990fe1

services/audioflinger/Threads.cpp

+9 −5
Original line number Diff line number Diff line
@@ -4066,14 +4066,18 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::OffloadThread::prepareTr 
                    track->mState = TrackBase::STOPPING_2; // so presentation completes after drain

                    // do not drain if no data was ever sent to HAL (mStandby == true)

                    if (last && !mStandby) {

                        // do not modify drain sequence if we are already draining. This happens

                        // when resuming from pause after drain.

                        if ((mDrainSequence & 1) == 0) {

                            sleepTime = 0;

                            standbyTime = systemTime() + standbyDelay;

                            mixerStatus = MIXER_DRAIN_TRACK;

                            mDrainSequence += 2;

                        }

                        if (mHwPaused) {

                            // It is possible to move from PAUSED to STOPPING_1 without

                            // a resume so we must ensure hardware is running

                            mOutput->stream->resume(mOutput->stream);

                            doHwResume = true;

                            mHwPaused = false;

                        }

                    }