Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ae3ce5e authored by Samiul Islam's avatar Samiul Islam
Browse files

Remove packagemanager_aidl from export_shared_lib_headers 

Unless a module is exporting libbinder as export_shared_lib_headers,
there is no reason for it to export packagemanager_aidl. Most of them
are consumers of packagemanager_aidl, not providers.

If Removing packagemanager_aidl from export_shared_lib_headers breaks
the build,  then it just means there is some module which is
relying on one of these modules with export_shared_lib_headers as
provider for packagemanager_aidl. We should update them accordingly.

Bug: 183654927
Test: builds + presubmit
Change-Id: I952ec5c58686e1263aabf95587851faf780fe7e1
parent 92da43cc

media/audioserver/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ cc_binary { 
    ],



    shared_libs: [

        "packagemanager_aidl-cpp",

        "libaaudioservice",

        "libaudioflinger",

        "libaudiopolicyservice",
@@ -41,7 +42,6 @@ cc_binary { 
        "libpowermanager",

        "libutils",

        "libvibrator",



    ],



    // TODO check if we still need all of these include directories

media/libaudioclient/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -133,6 +133,7 @@ cc_library { 
        "libutils",

        "libvibrator",

        "framework-permission-aidl-cpp",

        "packagemanager_aidl-cpp",

    ],

    export_shared_lib_headers: [

        "audioflinger-aidl-cpp",

media/libmediaplayerservice/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ cc_library { 
    export_shared_lib_headers: [

        "libmedia",

        "framework-permission-aidl-cpp",

        "packagemanager_aidl-cpp",

    ],



    include_dirs: [

media/libstagefright/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -373,7 +373,6 @@ cc_library { 
        "libmedia",

        "android.hidl.allocator@1.0",

        "framework-permission-aidl-cpp",

        "packagemanager_aidl-cpp",

    ],



    export_include_dirs: [

media/utils/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -72,7 +72,6 @@ cc_library { 


    export_shared_lib_headers: [

        "libpermission",

        "packagemanager_aidl-cpp",

    ],



    include_dirs: [