Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ad278b5 authored by Eric Laurent's avatar Eric Laurent
Browse files

mediautils : TimeCheck: fix OOB access 

Fix OOB access when reading from audioHalPids
in TimeCheck::accessAudioHalPids()

Bug: 175894436
Test: make
Change-Id: I436523e4909051f83fc916effbe2710d2d962168
parent 5faae759

media/utils/TimeCheck.cpp

+2 −3
Original line number Diff line number Diff line
@@ -39,10 +39,9 @@ void TimeCheck::accessAudioHalPids(std::vector<pid_t>* pids, bool update) { 
    static std::atomic<int> curAudioHalPids = 0;



    if (update) {

        audioHalPids[(curAudioHalPids + 1) % kNumAudioHalPidsVectors] = *pids;

        curAudioHalPids++;

        audioHalPids[(curAudioHalPids++ + 1) % kNumAudioHalPidsVectors] = *pids;

    } else {

        *pids = audioHalPids[curAudioHalPids];

        *pids = audioHalPids[curAudioHalPids % kNumAudioHalPidsVectors];

    }

}