Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19253093 authored by hkuang's avatar hkuang Committed by Hangyu Kuang
Browse files

transcoding: Add openFileDescriptor to ITranscodingClientCallback. 

This is used to open the file when transcoding service really
starts to process the job.

Bug: 145628554
Test: Build

Change-Id: I2d33e349052a1c14f0b3c99017a653666c52fb49
parent 3b587c7e

media/libmediatranscoding/aidl/android/media/ITranscodingClientCallback.aidl

+10 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ package android.media; 
import android.media.TranscodingErrorCode;

import android.media.TranscodingJobParcel;

import android.media.TranscodingResultParcel;

import android.os.ParcelFileDescriptor;



/**

 * ITranscodingClientCallback
@@ -28,6 +29,15 @@ import android.media.TranscodingResultParcel; 
 * {@hide}

 */

interface ITranscodingClientCallback {

    /**

    * Called to open a raw file descriptor to access data under a URI

    *

    * @param fileUri The path of the filename.

    * @param mode The file mode to use. Must be one of ("r, "w", "rw")

    * @return ParcelFileDescriptor if open the file successfully, null otherwise.

    */

    ParcelFileDescriptor openFileDescriptor(in @utf8InCpp String fileUri,

                                            in @utf8InCpp String mode);



    /**

    * Called when the transcoding associated with the jobId finished.

media/libmediatranscoding/tests/TranscodingClientManager_tests.cpp

+5 −0
Original line number Diff line number Diff line
@@ -59,6 +59,11 @@ struct TestClientCallback : public BnTranscodingClientCallback { 


    virtual ~TestClientCallback() { ALOGI("TestClientCallback destroyed"); };



    Status openFileDescriptor(const std::string& /*in_fileUri*/, const std::string& /*in_mode*/,

                              ::ndk::ScopedFileDescriptor* /*_aidl_return*/) override {

        return Status::ok();

    }



    Status onTranscodingFinished(int32_t in_jobId,

                                 const TranscodingResultParcel& in_result) override {

        EXPECT_EQ(in_jobId, in_result.jobId);

media/libmediatranscoding/tests/TranscodingJobScheduler_tests.cpp

+5 −0
Original line number Diff line number Diff line
@@ -162,6 +162,11 @@ struct TestClientCallback : public BnTranscodingClientCallback { 
        ALOGD("TestClient Created");

    }



    Status openFileDescriptor(const std::string& /*in_fileUri*/, const std::string& /*in_mode*/,

                              ::ndk::ScopedFileDescriptor* /*_aidl_return*/) override {

        return Status::ok();

    }



    Status onTranscodingFinished(int32_t in_jobId,

                                 const TranscodingResultParcel& in_result) override {

        EXPECT_EQ(in_jobId, in_result.jobId);

services/mediatranscoding/tests/mediatranscodingservice_tests.cpp

+5 −0
Original line number Diff line number Diff line
@@ -211,6 +211,11 @@ struct TestClientCallback : public BnTranscodingClientCallback, public EventTrac 


    virtual ~TestClientCallback() { ALOGI("TestClientCallback %d destroyed", mClientId); }



    Status openFileDescriptor(const std::string& /*in_fileUri*/, const std::string& /*in_mode*/,

                              ::ndk::ScopedFileDescriptor* /*_aidl_return*/) override {

        return Status::ok();

    }



    Status onTranscodingFinished(

            int32_t in_jobId,

            const ::aidl::android::media::TranscodingResultParcel& /* in_result */) override {