Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 140a34fb authored by jiabin's avatar jiabin Committed by Eric Laurent
Browse files

Check if calling uid is system uid for setAllowedPolicyCapture. 

AudioSystem.setAllowedPolicyCapture is only called from audio service.
In that case, checking if the calling uid is system uid to before taking
action.

Bug: 145115448
Test: dumpsys audio, query active playback configuration
Change-Id: I614ac881ecde6bad13f22f1382de701f314a7ada
parent 31f98910

media/libaudioclient/IAudioPolicyService.cpp

+2 −1
Original line number Diff line number Diff line
@@ -1451,7 +1451,8 @@ status_t BnAudioPolicyService::onTransact( 
        case SET_PREFERRED_DEVICE_FOR_PRODUCT_STRATEGY:

        case REMOVE_PREFERRED_DEVICE_FOR_PRODUCT_STRATEGY:

        case GET_PREFERRED_DEVICE_FOR_PRODUCT_STRATEGY:

        case GET_DEVICES_FOR_ATTRIBUTES: {

        case GET_DEVICES_FOR_ATTRIBUTES:

        case SET_ALLOWED_CAPTURE_POLICY: {

            if (!isServiceUid(IPCThreadState::self()->getCallingUid())) {

                ALOGW("%s: transaction %d received from PID %d unauthorized UID %d",

                      __func__, code, IPCThreadState::self()->getCallingPid(),

services/audiopolicy/service/AudioPolicyInterfaceImpl.cpp

+0 −5
Original line number Diff line number Diff line
@@ -1008,11 +1008,6 @@ status_t AudioPolicyService::setAllowedCapturePolicy(uid_t uid, audio_flags_mask 
        ALOGV("%s() mAudioPolicyManager == NULL", __func__);

        return NO_INIT;

    }

    uint_t callingUid = IPCThreadState::self()->getCallingUid();

    if (uid != callingUid) {

        ALOGD("%s() uid invalid %d != %d", __func__, uid, callingUid);

        return PERMISSION_DENIED;

    }

    return mAudioPolicyManager->setAllowedCapturePolicy(uid, capturePolicy);

}