Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12a5f28f authored by Sergio Giro's avatar Sergio Giro Committed by Martijn Coenen
Browse files

Add bound checks to utf16_to_utf8 

Bug: 29250543
Change-Id: I3518416e89ed901021970958fb6005fd69129f7c
(cherry picked from commit 1d3f4278)
parent 84183ba4

media/libmediaplayerservice/MediaPlayerService.cpp

+2 −1
Original line number Diff line number Diff line
@@ -237,7 +237,8 @@ void unmarshallAudioAttributes(const Parcel& parcel, audio_attributes_t *attribu 
            // copying array size -1, array for tags was calloc'd, no need to NULL-terminate it

            size_t tagSize = realTagSize > AUDIO_ATTRIBUTES_TAGS_MAX_SIZE - 1 ?

                    AUDIO_ATTRIBUTES_TAGS_MAX_SIZE - 1 : realTagSize;

            utf16_to_utf8(tags.string(), tagSize, attributes->tags);

            utf16_to_utf8(tags.string(), tagSize, attributes->tags,

                    sizeof(attributes->tags) / sizeof(attributes->tags[0]));

        }

    } else {

        ALOGE("unmarshallAudioAttributes() received unflattened tags, ignoring tag values");