Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 116a1894 authored by Chien-Yu Chen's avatar Chien-Yu Chen
Browse files

Camera3Device: Validate template ID 

Validate template ID before creating a default request.

Bug: 26866110
Bug: 27568958
Change-Id: Ifda457024f1d5c2b1382f189c1a8d5fda852d30d
parent 09e024fe

services/camera/libcameraservice/device3/Camera3Device.cpp

+8 −0
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ 
#include <utils/Trace.h>

#include <utils/Timers.h>



#include "CameraService.h"

#include "utils/CameraTraces.h"

#include "device3/Camera3Device.h"

#include "device3/Camera3OutputStream.h"
@@ -874,6 +875,13 @@ status_t Camera3Device::createDefaultRequest(int templateId, 
        CameraMetadata *request) {

    ATRACE_CALL();

    ALOGV("%s: for template %d", __FUNCTION__, templateId);



    if (templateId <= 0 || templateId >= CAMERA3_TEMPLATE_COUNT) {

        android_errorWriteWithInfoLog(CameraService::SN_EVENT_LOG_ID, "26866110",

                IPCThreadState::self()->getCallingUid(), NULL, 0);

        return BAD_VALUE;

    }



    Mutex::Autolock il(mInterfaceLock);

    Mutex::Autolock l(mLock);