Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 115b87ec authored by Jean-Michel Trivi's avatar Jean-Michel Trivi
Browse files

Fix track estimation for presentation complete 

Audio tracks were not using the right latency estimation for
 signalling the completion of their presetation. This caused
 the synchronization mechanism between playback and record to be
 off, and a synchronized recording would contain some of the audio
 that was meant to be over once recording would start.
Use the playback thread's latency reporting which takes the audio
 pipe into account.

Bug 7237669

Change-Id: I23a907a53ad0b0d68d246789ec595a77a79fced5
parent 6ebb6749

services/audioflinger/AudioFlinger.cpp

+2 −4
Original line number Diff line number Diff line
@@ -3275,8 +3275,7 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::MixerThread::prepareTrac 
                // Remove it from the list of active tracks.

                // TODO: use actual buffer filling status instead of latency when available from

                // audio HAL

                size_t audioHALFrames =

                        (mOutput->stream->get_latency(mOutput->stream)*mSampleRate) / 1000;

                size_t audioHALFrames = (latency_l() * mSampleRate) / 1000;

                size_t framesWritten =

                        mBytesWritten / audio_stream_frame_size(&mOutput->stream->common);

                if (track->presentationComplete(framesWritten, audioHALFrames)) {
@@ -3799,8 +3798,7 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::DirectOutputThread::prep 
                // We have consumed all the buffers of this track.

                // Remove it from the list of active tracks.

                // TODO: implement behavior for compressed audio

                size_t audioHALFrames =

                        (mOutput->stream->get_latency(mOutput->stream)*mSampleRate) / 1000;

                size_t audioHALFrames = (latency_l() * mSampleRate) / 1000;

                size_t framesWritten =

                        mBytesWritten / audio_stream_frame_size(&mOutput->stream->common);

                if (track->presentationComplete(framesWritten, audioHALFrames)) {