Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 110bc954 authored by Andy Hung's avatar Andy Hung
Browse files

Check effect command reply size in AudioFlinger 

Bug: 29251553
Change-Id: I1bcc1281f1f0542bb645f6358ce31631f2a8ffbf
parent dc7357d2

services/audioflinger/Effects.cpp

+6 −0
Original line number Diff line number Diff line
@@ -526,6 +526,12 @@ status_t AudioFlinger::EffectModule::command(uint32_t cmdCode, 
    if (mStatus != NO_ERROR) {

        return mStatus;

    }

    if (cmdCode == EFFECT_CMD_GET_PARAM &&

            (*replySize < sizeof(effect_param_t) ||

                    ((effect_param_t *)pCmdData)->psize > *replySize - sizeof(effect_param_t))) {

        android_errorWriteLog(0x534e4554, "29251553");

        return -EINVAL;

    }

    status_t status = (*mEffectInterface)->command(mEffectInterface,

                                                   cmdCode,

                                                   cmdSize,