Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10fb4bea authored by Andy Hung's avatar Andy Hung
Browse files

AudioTrack: Fix start logging spam. 

Test: OboeTester in OpenSL ES mode
Bug: 154868033
Change-Id: I0dc7b78c8982a5ce1ac79b1494af0f16b4a7bb48
parent 3fdcc346

media/libaudioclient/AudioTrack.cpp

+9 −7
Original line number Diff line number Diff line
@@ -639,9 +639,17 @@ exit: 


status_t AudioTrack::start()

{

    const int64_t beginNs = systemTime();

    AutoMutex lock(mLock);



    if (mState == STATE_ACTIVE) {

        return INVALID_OPERATION;

    }



    ALOGV("%s(%d): prior state:%s", __func__, mPortId, stateToString(mState));



    // Defer logging here due to OpenSL ES repeated start calls.

    // TODO(b/154868033) after fix, restore this logging back to the beginning of start().

    const int64_t beginNs = systemTime();

    status_t status = NO_ERROR; // logged: make sure to set this before returning.

    mediametrics::Defer defer([&] {

        mediametrics::LogItem(mMetricsId)
@@ -655,12 +663,6 @@ status_t AudioTrack::start() 
            .set(AMEDIAMETRICS_PROP_STATUS, (int32_t)status)

            .record(); });



    ALOGV("%s(%d): prior state:%s", __func__, mPortId, stateToString(mState));



    if (mState == STATE_ACTIVE) {

        status = INVALID_OPERATION;

        return status;

    }



    mInUnderrun = true;