Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1040da54 authored by Andy Hung's avatar Andy Hung
Browse files

AudioPolicyService: Fix mutex ordering issue

Test: Spatialization playback with order checking
Bug: 315240650
Change-Id: I8179352f0f503a67076bf4fd5328227861646bd5
parent e251446d
Loading
Loading
Loading
Loading
+4 −0
Original line number Diff line number Diff line
@@ -299,7 +299,11 @@ void AudioPolicyService::onFirstRef()
        AudioDeviceTypeAddrVector devices;
        bool hasSpatializer = mAudioPolicyManager->canBeSpatialized(&attr, nullptr, devices);
        if (hasSpatializer) {
            // Unlock as Spatializer::create() will use the callback and acquire the
            // AudioPolicyService_Mutex.
            mLock.unlock();
            mSpatializer = Spatializer::create(this, effectsFactoryHal);
            mLock.lock();
        }
        if (mSpatializer == nullptr) {
            // No spatializer created, signal the reason: NO_INIT a failure, OK means intended.