Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ff8b65f authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

libaudiohal: Remove unused protected methods from StreamHalAidl 

getHalPid and requestHalThreadPriority are not used
because in the AIDL model it's the responsibility of
the HAL service to set the priority for its threads.

Bug: 205884982
Test: m
Change-Id: I5278f544eadc184d109e3b396cc72b70a47d5557
parent 61e0b547

media/libaudiohal/impl/StreamHalAidl.cpp

+0 −13
Original line number Diff line number Diff line
@@ -478,19 +478,6 @@ status_t StreamHalAidl::setHalThreadPriority(int priority __unused) { 
    return OK;

}



status_t StreamHalAidl::getHalPid(pid_t *pid __unused) {

    ALOGD("%p %s::%s", this, getClassName().c_str(), __func__);

    TIME_CHECK();

    if (!mStream) return NO_INIT;

    ALOGE("%s not implemented yet", __func__);

    return OK;

}



bool StreamHalAidl::requestHalThreadPriority(pid_t threadPid __unused, pid_t threadId __unused) {

    // Obsolete, must be done by the HAL module.

    return true;

}



status_t StreamHalAidl::legacyCreateAudioPatch(const struct audio_port_config& port __unused,

                                               std::optional<audio_source_t> source __unused,

                                               audio_devices_t type __unused) {

media/libaudiohal/impl/StreamHalAidl.h

+0 −4
Original line number Diff line number Diff line
@@ -199,10 +199,6 @@ class StreamHalAidl : public virtual StreamHalInterface, public ConversionHelper 


    ~StreamHalAidl() override;



    status_t getHalPid(pid_t *pid);



    bool requestHalThreadPriority(pid_t threadPid, pid_t threadId);



    status_t getLatency(uint32_t *latency);



    status_t getObservablePosition(int64_t *frames, int64_t *timestamp);