Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eac0714 authored by Glenn Kasten's avatar Glenn Kasten Committed by Android (Google) Code Review
Browse files

Merge "Document AudioMixer hard-coded limits"

parents db3a20ea 599fabc5

services/audioflinger/AudioMixer.cpp

+6 −0
Original line number Diff line number Diff line
@@ -106,6 +106,12 @@ AudioMixer::AudioMixer(size_t frameCount, uint32_t sampleRate, uint32_t maxNumTr 
    ALOG_ASSERT(maxNumTracks <= MAX_NUM_TRACKS, "maxNumTracks %u > MAX_NUM_TRACKS %u",

            maxNumTracks, MAX_NUM_TRACKS);



    // AudioMixer is not yet capable of more than 32 active track inputs

    ALOG_ASSERT(32 >= MAX_NUM_TRACKS, "bad MAX_NUM_TRACKS %d", MAX_NUM_TRACKS);



    // AudioMixer is not yet capable of multi-channel output beyond stereo

    ALOG_ASSERT(2 == MAX_NUM_CHANNELS, "bad MAX_NUM_CHANNELS %d", MAX_NUM_CHANNELS);



    LocalClock lc;



    pthread_once(&sOnceControl, &sInitRoutine);

services/audioflinger/AudioMixer.h

+7 −0
Original line number Diff line number Diff line
@@ -41,8 +41,15 @@ public: 


    /*virtual*/             ~AudioMixer();  // non-virtual saves a v-table, restore if sub-classed





    // This mixer has a hard-coded upper limit of 32 active track inputs.

    // Adding support for > 32 tracks would require more than simply changing this value.

    static const uint32_t MAX_NUM_TRACKS = 32;

    // maximum number of channels supported by the mixer



    // This mixer has a hard-coded upper limit of 2 channels for output.

    // There is support for > 2 channel tracks down-mixed to 2 channel output via a down-mix effect.

    // Adding support for > 2 channel output would require more than simply changing this value.

    static const uint32_t MAX_NUM_CHANNELS = 2;

    // maximum number of channels supported for the content

    static const uint32_t MAX_NUM_CHANNELS_TO_DOWNMIX = 8;