Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ccba97e authored by Eino-Ville Talvala's avatar Eino-Ville Talvala
Browse files

Camera2: Fix transforms for front-facing cameras 

Mirror, mirror on the wall, who is the best rotated of them all?

Also, use consistent enum names.

Bug: 16637957
Change-Id: Ie211d3b57b9e7d01122192ad03b73ceba5bf1bd3
parent 7d70c5e5

camera/CameraUtils.cpp

+11 −4
Original line number Diff line number Diff line
@@ -73,18 +73,25 @@ status_t CameraUtils::getRotationTransform(const CameraMetadata& staticInfo, 
                return INVALID_OPERATION;

        }

    } else {

        // Front camera needs to be horizontally flipped for

        // mirror-like behavior.

        // Note: Flips are applied before rotates.

        switch (orientation) {

            case 0:

                flags = HAL_TRANSFORM_FLIP_H;

                flags = NATIVE_WINDOW_TRANSFORM_FLIP_H;

                break;

            case 90:

                flags = HAL_TRANSFORM_FLIP_H | HAL_TRANSFORM_ROT_90;

                flags = NATIVE_WINDOW_TRANSFORM_FLIP_H |

                        NATIVE_WINDOW_TRANSFORM_ROT_270;

                break;

            case 180:

                flags = HAL_TRANSFORM_FLIP_V;

                flags = NATIVE_WINDOW_TRANSFORM_FLIP_H |

                        NATIVE_WINDOW_TRANSFORM_ROT_180;

                break;

            case 270:

                flags = HAL_TRANSFORM_FLIP_V | HAL_TRANSFORM_ROT_90;

                flags = NATIVE_WINDOW_TRANSFORM_FLIP_H |

                        NATIVE_WINDOW_TRANSFORM_ROT_90;



                break;

            default:

                ALOGE("%s: Invalid HAL android.sensor.orientation value: %d",