Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bdc87aa authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Fix integer overflows 

Bug: 28938657
Change-Id: I85382a13db254169b03b284568469f0627869021
parent 7d58810b

media/libstagefright/avc_utils.cpp

+2 −2
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ unsigned parseUEWithFallback(ABitReader *br, unsigned fallback) { 
signed parseSE(ABitReader *br) {

    unsigned codeNum = parseUE(br);



    return (codeNum & 1) ? (codeNum + 1) / 2 : -(codeNum / 2);

    return (codeNum & 1) ? (codeNum + 1) / 2 : -signed(codeNum / 2);

}



signed parseSEWithFallback(ABitReader *br, signed fallback) {
@@ -71,7 +71,7 @@ signed parseSEWithFallback(ABitReader *br, signed fallback) { 
    if (codeNum == ~0U) {

        return fallback;

    }

    return (codeNum & 1) ? (codeNum + 1) / 2 : -(codeNum / 2);

    return (codeNum & 1) ? (codeNum + 1) / 2 : -signed(codeNum / 2);

}



static void skipScalingList(ABitReader *br, size_t sizeOfScalingList) {