Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09f9c023 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix undefined error in ALOGV_IF. 

Error found with clang static analyzer after
making ALOGV_IF to use its parameters.

Bug: 111850071
Test: build with WITH_TIDY
Change-Id: I35bdfd6583a106d82f30063cbd629bcff1d58289
parent 93adab13

media/libaudioprocessing/AudioMixer.cpp

+2 −2
Original line number Diff line number Diff line
@@ -875,7 +875,7 @@ void AudioMixer::process__validate() 
                t->hook = Track::getTrackHook(TRACKTYPE_RESAMPLE, t->mMixerChannelCount,

                        t->mMixerInFormat, t->mMixerFormat);

                ALOGV_IF((n & NEEDS_CHANNEL_COUNT__MASK) > NEEDS_CHANNEL_2,

                        "Track %d needs downmix + resample", i);

                        "Track %d needs downmix + resample", name);

            } else {

                if ((n & NEEDS_CHANNEL_COUNT__MASK) == NEEDS_CHANNEL_1){

                    t->hook = Track::getTrackHook(
@@ -890,7 +890,7 @@ void AudioMixer::process__validate() 
                    t->hook = Track::getTrackHook(TRACKTYPE_NORESAMPLE, t->mMixerChannelCount,

                            t->mMixerInFormat, t->mMixerFormat);

                    ALOGV_IF((n & NEEDS_CHANNEL_COUNT__MASK) > NEEDS_CHANNEL_2,

                            "Track %d needs downmix", i);

                            "Track %d needs downmix", name);

                }

            }

        }