Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 095e72ed authored by Wonsik Kim's avatar Wonsik Kim
Browse files

media.c2 client: fix # of queried param count 

Bug: 320568062
Test: atest VtsHalMediaC2V1_0TargetComponentTest
Change-Id: Ibfdaa9f954c0622a3c063eb8f4e5fe9e94a8f9f7
parent 0a075d67

media/codec2/hal/client/client.cpp

+3 −6
Original line number Diff line number Diff line
@@ -649,7 +649,7 @@ c2_status_t Codec2ConfigurableClient::AidlImpl::query( 
        return C2_CORRUPTED;

    }

    size_t i = 0;

    size_t numUpdatedStackParams = 0;

    size_t numQueried = 0;

    for (auto it = paramPointers.begin(); it != paramPointers.end(); ) {

        C2Param* paramPointer = *it;

        if (numStackIndices > 0) {
@@ -678,7 +678,7 @@ c2_status_t Codec2ConfigurableClient::AidlImpl::query( 
                continue;

            }

            if (stackParams[i++]->updateFrom(*paramPointer)) {

                ++numUpdatedStackParams;

                ++numQueried;

            } else {

                LOG(WARNING) << "query -- param update failed: "

                                "index = "
@@ -695,14 +695,11 @@ c2_status_t Codec2ConfigurableClient::AidlImpl::query( 
                                "unexpected extra stack param.";

            } else {

                heapParams->emplace_back(C2Param::Copy(*paramPointer));

                ++numQueried;

            }

        }

        ++it;

    }

    size_t numQueried = numUpdatedStackParams;

    if (heapParams) {

        numQueried += heapParams->size();

    }

    if (status == C2_OK && indices.size() != numQueried) {

        status = C2_BAD_INDEX;

    }