Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06fab720 authored by Linus Nilsson's avatar Linus Nilsson
Browse files

Transcoding service: Check client DUMP permission 

Fixes android.security.cts.ServicePermissionsTest#testDumpProtected test
by verifying the client's DUMP permission before dumping internal state.

Test: android.security.cts.ServicePermissionsTest#testDumpProtected
Test: Transcoding service unit test
Fixes: 161457160
Change-Id: I26dfe46d8cecb4eedca77d8b4047a526cb875930
parent 60c55599

services/mediatranscoding/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ cc_library_shared { 


    shared_libs: [

        "libbase",

        "libbinder",

        "libbinder_ndk",

        "libcutils",

        "liblog",

services/mediatranscoding/MediaTranscodingService.cpp

+11 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 


#include <android/binder_manager.h>

#include <android/binder_process.h>

#include <binder/IServiceManager.h>

#include <cutils/properties.h>

#include <media/TranscoderWrapper.h>

#include <media/TranscodingClientManager.h>
@@ -69,6 +70,16 @@ MediaTranscodingService::~MediaTranscodingService() { 


binder_status_t MediaTranscodingService::dump(int fd, const char** /*args*/, uint32_t /*numArgs*/) {

    String8 result;



    if (checkCallingPermission(String16("android.permission.DUMP")) == false) {

        result.format(

                "Permission Denial: "

                "can't dump MediaTranscodingService from pid=%d, uid=%d\n",

                AIBinder_getCallingPid(), AIBinder_getCallingUid());

        write(fd, result.string(), result.size());

        return PERMISSION_DENIED;

    }



    const size_t SIZE = 256;

    char buffer[SIZE];