Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0331cf73 authored by Glenn Kasten's avatar Glenn Kasten Committed by Android (Google) Code Review
Browse files

Merge "Pull up comment to superclass"

parents 27697a3d 8a0554c6
Loading
Loading
Loading
Loading
+0 −6
Original line number Diff line number Diff line
@@ -59,12 +59,6 @@ struct FastTrackDump {
    size_t              mFramesReady;        // most recent value only; no long-term statistics kept
};

// The FastMixerDumpState keeps a cache of FastMixer statistics that can be logged by dumpsys.
// Each individual native word-sized field is accessed atomically.  But the
// overall structure is non-atomic, that is there may be an inconsistency between fields.
// No barriers or locks are used for either writing or reading.
// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks).
// It has a different lifetime than the FastMixer, and so it can't be a member of FastMixer.
struct FastMixerDumpState : FastThreadDumpState {
    FastMixerDumpState();
    /*virtual*/ ~FastMixerDumpState();
+6 −1
Original line number Diff line number Diff line
@@ -22,7 +22,12 @@

namespace android {

// FIXME extract common part of comment at FastMixerDumpState
// The FastThreadDumpState keeps a cache of FastThread statistics that can be logged by dumpsys.
// Each individual native word-sized field is accessed atomically.  But the
// overall structure is non-atomic, that is there may be an inconsistency between fields.
// No barriers or locks are used for either writing or reading.
// Only POD types are permitted, and the contents shouldn't be trusted (i.e. do range checks).
// It has a different lifetime than the FastThread, and so it can't be a member of FastThread.
struct FastThreadDumpState {
    FastThreadDumpState();
    /*virtual*/ ~FastThreadDumpState();