Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0162d00a authored by Wei Jia's avatar Wei Jia
Browse files

AudioSink: use flags granted by AudioTrack, instead of the requested flags. 

Do not call AudioTrack::setPlaybackRate when DIRECT flag is set.

Bug: 17459982
Change-Id: Ib8fb07be72558234519590bcc3bb88c4f6edfa37
parent 9cf332ca

media/libmediaplayerservice/MediaPlayerService.cpp

+4 −2
Original line number Diff line number Diff line
@@ -1669,7 +1669,7 @@ status_t MediaPlayerService::AudioOutput::open( 
    t->setVolume(mLeftVolume, mRightVolume);



    mSampleRateHz = sampleRate;

    mFlags = flags;

    mFlags = t->getFlags(); // we suggest the flags above, but new AudioTrack() may not grant it.

    mMsecsPerFrame = 1E3f / (mPlaybackRate.mSpeed * sampleRate);

    uint32_t pos;

    if (t->getPosition(&pos) == OK) {
@@ -1678,7 +1678,9 @@ status_t MediaPlayerService::AudioOutput::open( 
    mTrack = t;



    status_t res = NO_ERROR;

    if ((flags & AUDIO_OUTPUT_FLAG_COMPRESS_OFFLOAD) == 0) {

    // Note some output devices may give us a direct track even though we don't specify it.

    // Example: Line application b/17459982.

    if ((mFlags & (AUDIO_OUTPUT_FLAG_COMPRESS_OFFLOAD | AUDIO_OUTPUT_FLAG_DIRECT)) == 0) {

        res = t->setPlaybackRate(mPlaybackRate);

        if (res == NO_ERROR) {

            t->setAuxEffectSendLevel(mSendLevel);