Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffdeacb3 authored by Alix's avatar Alix
Browse files

Add TODO comment for min_sdk_verison in android_app Bp2Build 

Test: NA added a comment
Bug: 274474008
Change-Id: I1c02c2877e638589730a7b2b565382c010dfe084
parent 895bc946

java/app.go

+1 −0
Original line number Diff line number Diff line
@@ -1522,6 +1522,7 @@ func (a *AndroidApp) ConvertWithBp2build(ctx android.TopDownMutatorContext) { 
	certificate, certificateName := android.BazelStringOrLabelFromProp(ctx, a.overridableAppProperties.Certificate)



	manifestValues := &manifestValueAttribute{}

	// TODO(b/274474008 ): Directly convert deviceProperties.Min_sdk_version in bp2build

	// MinSdkVersion(ctx) calls SdkVersion(ctx) if no value for min_sdk_version is set

	minSdkSpec := a.MinSdkVersion(ctx)

	if !minSdkSpec.ApiLevel.IsPreview() && minSdkSpec.Valid() {