Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fde8e6d3 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

RBE should not copy source file back to local 

Test: make with default RBE variables plus:
WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1
RBE_CLANG_TIDY=true
RBE_CLANG_TIDY_EXEC_STRATEGY=remote_local_fallback

Bug: b/157147559
Change-Id: I1c0106312910919cfda99b816cc8d0f9731b8bd1
parent 8f33dcc9

cc/builder.go

+7 −5
Original line number Diff line number Diff line
@@ -205,10 +205,12 @@ var ( 
			Labels:       map[string]string{"type": "lint", "tool": "clang-tidy", "lang": "cpp"},

			ExecStrategy: "${config.REClangTidyExecStrategy}",

			Inputs:       []string{"$in"},

			// OutputFile here is $in for remote-execution since its possible that

			// clang-tidy modifies the given input file itself and $out refers to the

			// ".tidy" file generated for ninja-dependency reasons.

			OutputFiles: []string{"$in"},

			// Although clang-tidy has an option to "fix" source files, that feature is hardly useable

			// under parallel compilation and RBE. So we assume no OutputFiles here.

			// The clang-tidy fix option is best run locally in single thread.

			// Copying source file back to local caused two problems:

			// (1) New timestamps trigger clang and clang-tidy compilations again.

			// (2) Changing source files caused concurrent clang or clang-tidy jobs to crash.

			Platform: map[string]string{remoteexec.PoolKey: "${config.REClangTidyPool}"},

		}, []string{"cFlags", "tidyFlags"}, []string{})