Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb5b31ce authored by Kweku Adams's avatar Kweku Adams
Browse files

Fixing protoOutParams concatenation. 

ParseGeneratorParameter delimits based on commas, not colons:
external/protobuf/src/google/protobuf/compiler/code_generator.cc

Bug: 72570104
Test: flash device with new build
Change-Id: I00042782a718d288ca6b0cb78f856d0fb223a926
parent 51ba4a79

cc/proto.go

+1 −1
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ func protoFlags(ctx ModuleContext, flags Flags, p *android.ProtoProperties) Flag 
	flags.protoFlags = android.ProtoFlags(ctx, p)



	if proptools.String(p.Proto.Type) == "lite" {

		flags.protoOutParams = []string{"lite"}

		flags.protoOutParams = append(flags.protoOutParams, "lite")

	}



	return flags

cc/util.go

+1 −1
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ func flagsToBuilderFlags(in Flags) builderFlags { 
		cppFlags:       strings.Join(in.CppFlags, " "),

		yaccFlags:      strings.Join(in.YaccFlags, " "),

		protoFlags:     strings.Join(in.protoFlags, " "),

		protoOutParams: strings.Join(in.protoOutParams, ":"),

		protoOutParams: strings.Join(in.protoOutParams, ","),

		aidlFlags:      strings.Join(in.aidlFlags, " "),

		rsFlags:        strings.Join(in.rsFlags, " "),

		ldFlags:        strings.Join(in.LdFlags, " "),