Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9c738d0 authored by Automerger Merge Worker's avatar Automerger Merge Worker
Browse files

Allow for setting a logging_parent for an Apex. am: 004d7171 am: f4fa3fe8 am: 83316272

Change-Id: Ifa85d785453e5e363b4b374ce0ea1d12963cafbb
parents 7eaafe07 83316272
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -1321,6 +1321,9 @@ type overridableProperties struct {
	// binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
	// from PRODUCT_PACKAGES.
	Overrides []string

	// Logging Parent value
	Logging_parent string
}

type apexPackaging int
+5 −0
Original line number Diff line number Diff line
@@ -3230,6 +3230,7 @@ func TestOverrideApex(t *testing.T) {
			base: "myapex",
			apps: ["override_app"],
			overrides: ["unknownapex"],
			logging_parent: "com.foo.bar",
		}

		apex_key {
@@ -3276,6 +3277,10 @@ func TestOverrideApex(t *testing.T) {
		t.Errorf("name should be \"override_myapex\", but was %q", name)
	}

	if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
		t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
	}

	data := android.AndroidMkDataForTest(t, config, "", apexBundle)
	var builder strings.Builder
	data.Custom(&builder, name, "TARGET_", "", data)
+4 −0
Original line number Diff line number Diff line
@@ -404,6 +404,10 @@ func (a *apexBundle) buildUnflattenedApex(ctx android.ModuleContext) {
		optFlags = append(optFlags, "--target_sdk_version "+targetSdkVersion)
		optFlags = append(optFlags, "--min_sdk_version "+minSdkVersion)

		if a.overridableProperties.Logging_parent != "" {
			optFlags = append(optFlags, "--logging_parent ", a.overridableProperties.Logging_parent)
		}

		a.mergedNotices = a.buildNoticeFiles(ctx, a.Name()+suffix)
		if a.mergedNotices.HtmlGzOutput.Valid() {
			// If there's a NOTICE file, embed it as an asset file in the APEX.