Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f29ca58e authored by A. Cody Schuffelen's avatar A. Cody Schuffelen
Browse files

Darwin/Mac OS host rust compilation fixes 

- Don't pass `--as-needed` to the linker on Mac OS which is unsupported
  there
- Use `--force_load` rather than `--Wl,--whole-archive` on Mac OS
- Scan `rustc`'s linker arguments for `-dylib` and `-dynamiclib`, which
  it can use instead of `-shared` on Mac OS:
  https://github.com/rust-lang/rust/blob/7bd81ee1902c049691d0a1f03be5558bee51d100/compiler/rustc_codegen_ssa/src/back/linker.rs#L319

Test: m libhalf serde_derive
Bug: 291164566
Change-Id: Iecd6c2532fa31c9476834f49b109de98cbd2dccf
parent cfe9e6d0

rust/builder.go

+15 −5
Original line number Diff line number Diff line
@@ -45,9 +45,9 @@ var ( 
		"rustcFlags", "libFlags", "envVars")

	rustLink = pctx.AndroidStaticRule("rustLink",

		blueprint.RuleParams{

			Command: "${config.RustLinker} -o $out ${crtBegin} ${config.RustLinkerArgs} @$in ${linkFlags} ${crtEnd}",

			Command: "${config.RustLinker} -o $out ${crtBegin} ${earlyLinkFlags} @$in ${linkFlags} ${crtEnd}",

		},

		"linkFlags", "crtBegin", "crtEnd")

		"earlyLinkFlags", "linkFlags", "crtBegin", "crtEnd")



	_       = pctx.SourcePathVariable("rustdocCmd", "${config.RustBin}/rustdoc")

	rustdoc = pctx.AndroidStaticRule("rustdoc",
@@ -244,6 +244,10 @@ func rustEnvVars(ctx ModuleContext, deps PathDeps) []string { 


	envVars = append(envVars, "AR=${cc_config.ClangBin}/llvm-ar")



	if ctx.Darwin() {

		envVars = append(envVars, "ANDROID_RUST_DARWIN=true")

	}



	return envVars

}
@@ -254,6 +258,7 @@ func transformSrctoCrate(ctx ModuleContext, main android.Path, deps PathDeps, fl 
	var implicits, linkImplicits, linkOrderOnly android.Paths

	var output buildOutput

	var rustcFlags, linkFlags []string

	var earlyLinkFlags string



	output.outputFile = outputFile

	crateName := ctx.RustModule().CrateName()
@@ -292,6 +297,10 @@ func transformSrctoCrate(ctx ModuleContext, main android.Path, deps PathDeps, fl 
	}



	// Collect linker flags

	if !ctx.Darwin() {

		earlyLinkFlags = "-Wl,--as-needed"

	}



	linkFlags = append(linkFlags, flags.GlobalLinkFlags...)

	linkFlags = append(linkFlags, flags.LinkFlags...)
@@ -391,6 +400,7 @@ func transformSrctoCrate(ctx ModuleContext, main android.Path, deps PathDeps, fl 
			Implicits:   linkImplicits,

			OrderOnly:   linkOrderOnly,

			Args: map[string]string{

				"earlyLinkFlags": earlyLinkFlags,

				"linkFlags":      strings.Join(linkFlags, " "),

				"crtBegin":       strings.Join(deps.CrtBegin.Strings(), " "),

				"crtEnd":         strings.Join(deps.CrtEnd.Strings(), " "),

rust/config/global.go

+0 −1
Original line number Diff line number Diff line
@@ -102,7 +102,6 @@ func init() { 


	pctx.ImportAs("cc_config", "android/soong/cc/config")

	pctx.StaticVariable("RustLinker", "${cc_config.ClangBin}/clang++")

	pctx.StaticVariable("RustLinkerArgs", "-Wl,--as-needed")



	pctx.StaticVariable("DeviceGlobalLinkFlags", strings.Join(deviceGlobalLinkFlags, " "))

scripts/mkcratersp.py

+9 −3
Original line number Diff line number Diff line
@@ -48,6 +48,8 @@ for i, arg in enumerate(sys.argv): 
    linkdirs.append(sys.argv[i+1])

  if arg.startswith('-l') or arg == '-shared':

    libs.append(arg)

  if os.getenv('ANDROID_RUST_DARWIN') and (arg == '-dylib' or arg == '-dynamiclib'):

    libs.append(arg)

  if arg.startswith('-Wl,--version-script='):

    version_script = arg[21:]

  if arg[0] == '-':
@@ -64,6 +66,10 @@ create_archive(f'{out}.whole.a', objects, []) 
create_archive(f'{out}.a', [], temp_archives)



with open(out, 'w') as f:

  if os.getenv("ANDROID_RUST_DARWIN"):

    print(f'-force_load', file=f)

    print(f'{out}.whole.a', file=f)

  else:

    print(f'-Wl,--whole-archive', file=f)

    print(f'{out}.whole.a', file=f)

    print(f'-Wl,--no-whole-archive', file=f)