Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1f6dd17 authored by Pirama Arumuga Nainar's avatar Pirama Arumuga Nainar
Browse files

[rust/coverage] Use new flag for coverage instrumentation 

> warning: `-Z instrument-coverage` is deprecated; use `-C
instrument-coverage`

Test: above warning is absent when running:
    $ m CLANG_COVERAGE=true NATIVE_COVERAGE_PATHS=* rust
Change-Id: I8687c04534db3c8a67f209b93ed13d54c2f86dc8
parent ba4a566e

rust/coverage.go

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ func (cov *coverage) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags 
		flags.Coverage = true

		coverage := ctx.GetDirectDepWithTag(CovLibraryName, cc.CoverageDepTag).(cc.LinkableInterface)

		flags.RustFlags = append(flags.RustFlags,

			"-Z instrument-coverage", "-g")

			"-C instrument-coverage", "-g")

		flags.LinkFlags = append(flags.LinkFlags,

			profileInstrFlag, "-g", coverage.OutputFile().Path().String(), "-Wl,--wrap,open")

		deps.StaticLibs = append(deps.StaticLibs, coverage.OutputFile().Path())

rust/coverage_test.go

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ func TestCoverageFlags(t *testing.T) { 
	fizzCov := ctx.ModuleForTests("fizz_cov", "android_arm64_armv8-a_cov").Rule("rustc")

	buzzNoCov := ctx.ModuleForTests("buzzNoCov", "android_arm64_armv8-a").Rule("rustc")



	rustcCoverageFlags := []string{"-Z instrument-coverage", " -g "}

	rustcCoverageFlags := []string{"-C instrument-coverage", " -g "}

	for _, flag := range rustcCoverageFlags {

		missingErrorStr := "missing rustc flag '%s' for '%s' module with coverage enabled; rustcFlags: %#v"

		containsErrorStr := "contains rustc flag '%s' for '%s' module with coverage disabled; rustcFlags: %#v"