Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3838731 authored by Bob Badour's avatar Bob Badour
Browse files

Fix gen_notice init to support arch and dist. 

Incorrect init function was called so Stem property was not handled
correctly and the dist properties were treated as unknown.

Test: m droid dist
Change-Id: I5eb8771afb4fda332df08cf1560df5c17d1316cc
parent 263efde0

android/gen_notice.go

+1 −1
Original line number Diff line number Diff line
@@ -179,7 +179,7 @@ func GenNoticeFactory() Module { 
	// The visibility property needs to be checked and parsed by the visibility module.

	setPrimaryVisibilityProperty(module, "visibility", &module.properties.Visibility)



	initAndroidModuleBase(module)

	InitAndroidArchModule(module, DeviceSupported, MultilibCommon)

	InitDefaultableModule(module)



	return module

android/gen_notice_test.go

+0 −13
Original line number Diff line number Diff line
@@ -11,19 +11,6 @@ var genNoticeTests = []struct { 
	fs             MockFS

	expectedErrors []string

}{

	{

		name: "gen_notice must not accept licenses property",

		fs: map[string][]byte{

			"top/Android.bp": []byte(`

				gen_notice {

					name: "top_license",

					licenses: ["other_license"],

				}`),

		},

		expectedErrors: []string{

			`unrecognized property "licenses"`,

		},

	},

	{

		name: "bad gen_notice",

		fs: map[string][]byte{