Merge "export clang-tidy extraArgFlags to Bazel" (d87f61ba) · Commits · e / os / android_build_soong

cc/config/tidy.go

+21 −0

Original line number	Diff line number	Diff line
		@@ -55,6 +55,21 @@ var (
		// http://b/241819232
		"-misc-const-correctness",
		}

		extraArgFlags = []string{
		// We might be using the static analyzer through clang tidy.
		// https://bugs.llvm.org/show_bug.cgi?id=32914
		"-D__clang_analyzer__",

		// A recent change in clang-tidy (r328258) enabled destructor inlining, which
		// appears to cause a number of false positives. Until that's resolved, this turns
		// off the effects of r328258.
		// https://bugs.llvm.org/show_bug.cgi?id=37459
		"-Xclang",
		"-analyzer-config",
		"-Xclang",
		"c++-temp-dtor-inlining=false",
		}
		)

		func init() {
		@@ -145,6 +160,8 @@ func init() {
		return strings.Join(globalNoErrorCheckList, ",")
		})

		exportedVars.ExportStringListStaticVariable("TidyExtraArgFlags", extraArgFlags)

		// To reduce duplicate warnings from the same header files,
		// header-filter will contain only the module directory and
		// those specified by DEFAULT_TIDY_HEADER_DIRS.
		@@ -235,6 +252,10 @@ func TidyGlobalNoErrorChecks() string {
		return ""
		}

		func TidyExtraArgFlags() []string {
		return extraArgFlags
		}

		func TidyFlagsForSrcFile(srcFile android.Path, flags string) string {
		// Disable clang-analyzer-* checks globally for generated source files
		// because some of them are too huge. Local .bp files can add wanted

+1 −13

Original line number	Diff line number	Diff line
		@@ -136,19 +136,7 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
		flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before=-fno-caret-diagnostics")
		}

		extraArgFlags := []string{
		// We might be using the static analyzer through clang tidy.
		// https://bugs.llvm.org/show_bug.cgi?id=32914
		"-D__clang_analyzer__",

		// A recent change in clang-tidy (r328258) enabled destructor inlining, which
		// appears to cause a number of false positives. Until that's resolved, this turns
		// off the effects of r328258.
		// https://bugs.llvm.org/show_bug.cgi?id=37459
		"-Xclang", "-analyzer-config", "-Xclang", "c++-temp-dtor-inlining=false",
		}

		for _, f := range extraArgFlags {
		for _, f := range config.TidyExtraArgFlags() {
		flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before="+f)
		}