Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7434e28 authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

For llndk libraries add -consider-opaque-types-different to header-abi-diff invocation. 



Bug: 79576032

Test: Create abi reference for libmediandk; build libmediandk;
      header-abi-diff gets invoked with '-consider-opaque-types-different'

Change-Id: I132138e333cc944b54051243b44fa072af74aa83
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent 6a25de47

cc/builder.go

+5 −2
Original line number Diff line number Diff line
@@ -726,11 +726,14 @@ func SourceAbiDiff(ctx android.ModuleContext, inputDump android.Path, referenceD 
	baseName, exportedHeaderFlags string, isVndkExt bool) android.OptionalPath {



	outputFile := android.PathForModuleOut(ctx, baseName+".abidiff")



	libName := strings.TrimSuffix(baseName, filepath.Ext(baseName))

	localAbiCheckAllowFlags := append([]string(nil), abiCheckAllowFlags...)

	if exportedHeaderFlags == "" {

		localAbiCheckAllowFlags = append(localAbiCheckAllowFlags, "-advice-only")

	}

	if inList(libName, llndkLibraries) {

		localAbiCheckAllowFlags = append(localAbiCheckAllowFlags, "-consider-opaque-types-different")

	}

	if isVndkExt {

		localAbiCheckAllowFlags = append(localAbiCheckAllowFlags, "-allow-extensions")

	}
@@ -743,7 +746,7 @@ func SourceAbiDiff(ctx android.ModuleContext, inputDump android.Path, referenceD 
		Implicit:    referenceDump,

		Args: map[string]string{

			"referenceDump": referenceDump.String(),

			"libName":       baseName[0:(len(baseName) - len(filepath.Ext(baseName)))],

			"libName":       libName,

			"arch":          ctx.Arch().ArchType.Name,

			"allowFlags":    strings.Join(localAbiCheckAllowFlags, " "),

		},