Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2d50487 authored by Colin Cross's avatar Colin Cross
Browse files

Prevent kotlinc from reading /tmp/build.txt 

Pass -Didea.plugins.compatible.build=999.SNAPSHOT to kotlinc and kapt
to prevent it from reading /tmp/build.txt and failing with an obscure
exception:
exception: java.lang.ExceptionInInitializerError
	at com.intellij.openapi.util.BuildNumber.currentVersion(BuildNumber.java:297)
...

Bug: 222162908
Test: m metalava with /tmp/build.txt present
Change-Id: I5faced4a2e94561ce3aa37bfaacf5bd7d988a4f0
parent 3f57c6a2

java/config/kotlin.go

+5 −0
Original line number Diff line number Diff line
@@ -47,4 +47,9 @@ func init() { 
	pctx.StaticVariable("KotlincSuppressJDK9Warnings", strings.Join([]string{

		"-J--add-opens=java.base/java.util=ALL-UNNAMED", // https://youtrack.jetbrains.com/issue/KT-43704

	}, " "))



	pctx.StaticVariable("KotlincGlobalFlags", strings.Join([]string{

		// b/222162908: prevent kotlinc from reading /tmp/build.txt

		"-Didea.plugins.compatible.build=999.SNAPSHOT",

	}, " "))

}

java/kotlin.go

+4 −2
Original line number Diff line number Diff line
@@ -34,7 +34,8 @@ var kotlinc = pctx.AndroidRemoteStaticRule("kotlinc", android.RemoteRuleSupports 
			`${config.GenKotlinBuildFileCmd} --classpath "$classpath" --name "$name"` +

			` --out_dir "$classesDir" --srcs "$out.rsp" --srcs "$srcJarDir/list"` +

			` $commonSrcFilesArg --out "$kotlinBuildFile" && ` +

			`${config.KotlincCmd} ${config.KotlincSuppressJDK9Warnings} ${config.JavacHeapFlags} ` +

			`${config.KotlincCmd} ${config.KotlincGlobalFlags} ` +

			`${config.KotlincSuppressJDK9Warnings} ${config.JavacHeapFlags} ` +

			`$kotlincFlags -jvm-target $kotlinJvmTarget -Xbuild-file=$kotlinBuildFile ` +

			`-kotlin-home $emptyDir && ` +

			`${config.SoongZipCmd} -jar -o $out -C $classesDir -D $classesDir && ` +
@@ -125,7 +126,8 @@ var kapt = pctx.AndroidRemoteStaticRule("kapt", android.RemoteRuleSupports{Goma: 
			`${config.GenKotlinBuildFileCmd} --classpath "$classpath" --name "$name"` +

			` --srcs "$out.rsp" --srcs "$srcJarDir/list"` +

			` $commonSrcFilesArg --out "$kotlinBuildFile" && ` +

			`${config.KotlincCmd} ${config.KaptSuppressJDK9Warnings} ${config.KotlincSuppressJDK9Warnings} ` +

			`${config.KotlincCmd} ${config.KotlincGlobalFlags} ` +

			`${config.KaptSuppressJDK9Warnings} ${config.KotlincSuppressJDK9Warnings} ` +

			`${config.JavacHeapFlags} $kotlincFlags -Xplugin=${config.KotlinKaptJar} ` +

			`-P plugin:org.jetbrains.kotlin.kapt3:sources=$kaptDir/sources ` +

			`-P plugin:org.jetbrains.kotlin.kapt3:classes=$kaptDir/classes ` +