Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc220ca8 authored by Yi Kong's avatar Yi Kong
Browse files

Forbid -fwhole_program_vtables 

-fwhole_program_vtables depends on LTO being enabled. User manually
adding this through ldflag will break no LTO build configuration.

Test: TreeHugger
Change-Id: I557ec57831f01856a467f9567c3e7e25f8a6c566
parent c5a0e64d

cc/check.go

+2 −0
Original line number Diff line number Diff line
@@ -38,6 +38,8 @@ func CheckBadCompilerFlags(ctx BaseModuleContext, prop string, flags []string) { 
			ctx.PropertyErrorf(prop, "Illegal flag `%s`", flag)

		} else if flag == "--coverage" {

			ctx.PropertyErrorf(prop, "Bad flag: `%s`, use native_coverage instead", flag)

		} else if flag == "-fwhole-program-vtables" {

			ctx.PropertyErrorf(prop, "Bad flag: `%s`, use whole_program_vtables instead", flag)

		} else if flag == "-Weverything" {

			if !ctx.Config().IsEnvTrue("ANDROID_TEMPORARILY_ALLOW_WEVERYTHING") {

				ctx.PropertyErrorf(prop, "-Weverything is not allowed in Android.bp files.  "+