Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f876e9e authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh Committed by Chih-hung Hsieh
Browse files

Set NoWarningsAsErrorsInTidyFlags 

* Reject -warnings-as-errors in the tidy_flags.
* Fix one grammar error in comment.

Bug: 229801437
Test: WITH_TIDY=1 make; make tidy-soong_subset
Change-Id: I4fae229add65131b64cd5a1d06507d27198010ed
parent 802b0594

cc/config/tidy.go

+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ import ( 
)



var (

	// Some clang-tidy checks have bugs or not work for Android.

	// Some clang-tidy checks have bugs or don't work for Android.

	// They are disabled here, overriding any locally selected checks.

	globalNoCheckList = []string{

		// https://b.corp.google.com/issues/153464409

cc/tidy.go

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ func (tidy *tidyFeature) props() []interface{} { 
// Set this const to true when all -warnings-as-errors in tidy_flags

// are replaced with tidy_checks_as_errors.

// Then, that old style usage will be obsolete and an error.

const NoWarningsAsErrorsInTidyFlags = false

const NoWarningsAsErrorsInTidyFlags = true



func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {

	CheckBadTidyFlags(ctx, "tidy_flags", tidy.Properties.Tidy_flags)