Commit 9bcce2ef authored Feb 07, 2022 by Chih-Hung Hsieh

Disable tidy default DeprecatedOrUnsafeBufferHandling check

This will suppress warning like:
system/chre/chpp/app.c:637:3: warning: Call to function 'memset' is insecure
as it does not provide security checks introduced in the C11 standard.
Replace with analogous functions that support length arguments or provides
boundary checks such as 'memset_s' in case of C11
[clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]

Test: WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1 make tidy-system-chre-chpp_subset
Change-Id: I87a7bba31aa10260fc408317a8cd54bf80c03152

parent 75664acd

cc/config/tidy.go

+2 −1

Original line number	Diff line number	Diff line
		@@ -62,8 +62,9 @@ func init() {
		}, ",")
		// clang-analyzer-* checks are too slow to be in the default for WITH_TIDY=1.
		// nightly builds add CLANG_ANALYZER_CHECKS=1 to run those checks.
		// The insecureAPI.DeprecatedOrUnsafeBufferHandling warning does not apply to Android.
		if ctx.Config().IsEnvTrue("CLANG_ANALYZER_CHECKS") {
		checks += ",clang-analyzer-*"
		checks += ",clang-analyzer-*,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling"
		}
		return checks
		})