Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9450d0b2 authored by Patrice Arruda's avatar Patrice Arruda
Browse files

soong_ui: Do not find a build file if targets are specified. 

For mmma and mmm, the findBuildFile function in config.go is invoked every time
for specified directories and directories with targets. For directories with
targets, an Android build file must exist in the directory where mmma and mmm
was invoked. There is no need to invoke findBuildFile function as a
simple check of the build file exists in the specified directory.

This is also refactoring the code for b/118730755

Bug: b/118730755
Test: Executed unit test cases through Intellij and executed mmma
command: "mmma external/protobuf:aprotoc external/bzip2".

Change-Id: I5428e3a3c36f77ff740617564b7853705521f29f
parent ae113186

ui/build/config.go

+29 −21
Original line number Diff line number Diff line
@@ -61,6 +61,8 @@ type configImpl struct { 


const srcDirFileCheck = "build/soong/root.bp"



var buildFiles = []string{"Android.mk", "Android.bp"}



type BuildAction uint



const (
@@ -344,6 +346,20 @@ func convertToTarget(dir string, targetNamePrefix string) string { 
	return targetNamePrefix + strings.ReplaceAll(dir, "/", "-")

}



// hasBuildFile returns true if dir contains an Android build file.

func hasBuildFile(ctx Context, dir string) bool {

	for _, buildFile := range buildFiles {

		_, err := os.Stat(filepath.Join(dir, buildFile))

		if err == nil {

			return true

		}

		if !os.IsNotExist(err) {

			ctx.Fatalf("Error retrieving the build file stats: %v", err)

		}

	}

	return false

}



// findBuildFile finds a build file (makefile or blueprint file) by looking at dir first. If not

// found, go up one level and repeat again until one is found and the path of that build file

// relative to the root directory of the source tree is returned. The returned filename of build
@@ -355,16 +371,9 @@ func findBuildFile(ctx Context, dir string) string { 
	}



	for ; dir != "."; dir = filepath.Dir(dir) {

		for _, buildFile := range []string{"Android.bp", "Android.mk"} {

			_, err := os.Stat(filepath.Join(dir, buildFile))

			if err == nil {

				// Returning the filename Android.mk as it might be used for ONE_SHOT_MAKEFILE variable.

		if hasBuildFile(ctx, dir) {

			return filepath.Join(dir, "Android.mk")

		}

			if !os.IsNotExist(err) {

				ctx.Fatalf("Error retrieving the build file stats: %v", err)

			}

		}

	}



	return ""
@@ -428,24 +437,23 @@ func getTargetsFromDirs(ctx Context, relDir string, dirs []string, targetNamePre 
			}

		}



		buildFile := findBuildFile(ctx, dir)

		if buildFile == "" {

			ctx.Fatalf("Build file not found for %s directory", dir)

		}

		buildFileDir := filepath.Dir(buildFile)



		// If there are specified targets, find the build file in the directory. If dir does not

		// contain the build file, bail out as it is required for one shot build. If there are no

		// target specified, build all the modules in dir (or the closest one in the dir path).

		// If there are specified targets to build in dir, an android build file must exist for the one

		// shot build. For the non-targets case, find the appropriate build file and build all the

		// modules in dir (or the closest one in the dir path).

		if len(newTargets) > 0 {

			if buildFileDir != dir {

			if !hasBuildFile(ctx, dir) {

				ctx.Fatalf("Couldn't locate a build file from %s directory", dir)

			}

			buildFiles = append(buildFiles, filepath.Join(dir, "Android.mk"))

		} else {

			newTargets = []string{convertToTarget(buildFileDir, targetNamePrefix)}

			buildFile := findBuildFile(ctx, dir)

			if buildFile == "" {

				ctx.Fatalf("Build file not found for %s directory", dir)

			}



			newTargets = []string{convertToTarget(filepath.Dir(buildFile), targetNamePrefix)}

			buildFiles = append(buildFiles, buildFile)

		}



		targets = append(targets, newTargets...)

	}

ui/build/config_test.go

+1 −1
Original line number Diff line number Diff line
@@ -441,7 +441,7 @@ func TestConfigGetTargets(t *testing.T) { 
		buildFiles:  []string{},

		dirs:        []string{"1/2/3:t1"},

		curDir:      "0",

		errStr:      "Build file not found for 0/1/2/3 directory",

		errStr:      "Couldn't locate a build file from 0/1/2/3 directory",

	}, {

		description: "one target dir specified, one target specified, build file not in target dir",

		dirsInTrees: []string{"0/1/2/3"},