Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f8cc166 authored by Krzysztof Kosiński's avatar Krzysztof Kosiński
Browse files

Globally disable -Wreorder-init-list. 

This warning is triggered even when initializers don't have any
side effects, so it very rarely surfaces actual bugs/mistakes.
99% of the time it complains about a purely cosmetic issue.
Disable it by default in commonGlobalCFlags, which still allows
individual modules to opt into it.

Bug: 145210666
Test: presubmit
Change-Id: I671b5c457ee3d92b9cc37f020ba54e01e1a04f59
parent 41932863

cc/config/global.go

+8 −2
Original line number Diff line number Diff line
@@ -69,8 +69,6 @@ var ( 
		// Making deprecated usages an error causes extreme pain when trying to

		// deprecate anything.

		"-Wno-error=deprecated-declarations",

		// This rarely indicates a bug. http://b/145210666

		"-Wno-error=reorder-init-list",



		// Warnings disabled by default.
@@ -86,6 +84,14 @@ var ( 
		// subsequent version of an interface, so this warning is currently

		// infeasible to enable.

		"-Wno-inconsistent-missing-override",

		// Detects designated initializers that are in a different order than

		// the fields in the initialized type, which causes the side effects

		// of initializers to occur out of order with the source code.

		// In practice, this warning has extremely poor signal to noise ratio,

		// because it is triggered even for initializers with no side effects.

		// Individual modules can still opt into it via cflags.

		"-Wno-error=reorder-init-list",

		"-Wno-reorder-init-list",

		// Incompatible with the Google C++ style guidance to use 'int' for loop

		// indices; poor signal to noise ratio.

		"-Wno-sign-compare",