Add more afdo testing (8c8e8d52) · Commits · e / os / android_build_soong

cc/afdo_test.go

+100 −18

Original line number	Diff line number	Diff line
		@@ -15,28 +15,46 @@
		package cc

		import (
		"strings"
		"testing"

		"android/soong/android"

		"github.com/google/blueprint"
		)

		type visitDirectDepsInterface interface {
		VisitDirectDeps(blueprint.Module, func(dep blueprint.Module))
		}

		func hasDirectDep(ctx visitDirectDepsInterface, m android.Module, wantDep android.Module) bool {
		var found bool
		ctx.VisitDirectDeps(m, func(dep blueprint.Module) {
		if dep == wantDep {
		found = true
		}
		})
		return found
		}

		func TestAfdoDeps(t *testing.T) {
		bp := `
		cc_library {
		cc_library_shared {
		name: "libTest",
		srcs: ["foo.c"],
		srcs: ["test.c"],
		static_libs: ["libFoo"],
		afdo: true,
		}

		cc_library {
		cc_library_static {
		name: "libFoo",
		srcs: ["foo.c"],
		static_libs: ["libBar"],
		}

		cc_library {
		cc_library_static {
		name: "libBar",
		srcs: ["bar.c"],
		}
		`
		prepareForAfdoTest := android.FixtureAddTextFile("toolchain/pgo-profiles/sampling/libTest.afdo", "TEST")
		@@ -46,25 +64,89 @@ func TestAfdoDeps(t *testing.T) {
		prepareForAfdoTest,
		).RunTestWithBp(t, bp)

		libTest := result.ModuleForTests("libTest", "android_arm64_armv8-a_shared").Module()
		libFoo := result.ModuleForTests("libFoo", "android_arm64_armv8-a_static_afdo-libTest").Module()
		libBar := result.ModuleForTests("libBar", "android_arm64_armv8-a_static_afdo-libTest").Module()
		libTest := result.ModuleForTests("libTest", "android_arm64_armv8-a_shared")
		libFoo := result.ModuleForTests("libFoo", "android_arm64_armv8-a_static_afdo-libTest")
		libBar := result.ModuleForTests("libBar", "android_arm64_armv8-a_static_afdo-libTest")

		hasDep := func(m android.Module, wantDep android.Module) bool {
		var found bool
		result.VisitDirectDeps(m, func(dep blueprint.Module) {
		if dep == wantDep {
		found = true
		if !hasDirectDep(result, libTest.Module(), libFoo.Module()) {
		t.Errorf("libTest missing dependency on afdo variant of libFoo")
		}
		})
		return found

		if !hasDirectDep(result, libFoo.Module(), libBar.Module()) {
		t.Errorf("libTest missing dependency on afdo variant of libBar")
		}

		cFlags := libTest.Rule("cc").Args["cFlags"]
		if w := "-fprofile-sample-accurate"; !strings.Contains(cFlags, w) {
		t.Errorf("Expected 'libTest' to enable afdo, but did not find %q in cflags %q", w, cFlags)
		}

		if !hasDep(libTest, libFoo) {
		cFlags = libFoo.Rule("cc").Args["cFlags"]
		if w := "-fprofile-sample-accurate"; !strings.Contains(cFlags, w) {
		t.Errorf("Expected 'libFoo' to enable afdo, but did not find %q in cflags %q", w, cFlags)
		}

		cFlags = libBar.Rule("cc").Args["cFlags"]
		if w := "-fprofile-sample-accurate"; !strings.Contains(cFlags, w) {
		t.Errorf("Expected 'libBar' to enable afdo, but did not find %q in cflags %q", w, cFlags)
		}
		}

		func TestAfdoEnabledOnStaticDepNoAfdo(t *testing.T) {
		bp := `
		cc_library_shared {
		name: "libTest",
		srcs: ["foo.c"],
		static_libs: ["libFoo"],
		}

		cc_library_static {
		name: "libFoo",
		srcs: ["foo.c"],
		static_libs: ["libBar"],
		afdo: true, // TODO(b/256670524): remove support for enabling afdo from static only libraries, this can only propagate from shared libraries/binaries
		}

		cc_library_static {
		name: "libBar",
		}
		`
		prepareForAfdoTest := android.FixtureAddTextFile("toolchain/pgo-profiles/sampling/libFoo.afdo", "TEST")

		result := android.GroupFixturePreparers(
		prepareForCcTest,
		prepareForAfdoTest,
		).RunTestWithBp(t, bp)

		libTest := result.ModuleForTests("libTest", "android_arm64_armv8-a_shared").Module()
		libFoo := result.ModuleForTests("libFoo", "android_arm64_armv8-a_static")
		libBar := result.ModuleForTests("libBar", "android_arm64_armv8-a_static").Module()

		if !hasDirectDep(result, libTest, libFoo.Module()) {
		t.Errorf("libTest missing dependency on afdo variant of libFoo")
		}

		if !hasDep(libFoo, libBar) {
		t.Errorf("libTest missing dependency on afdo variant of libBar")
		if !hasDirectDep(result, libFoo.Module(), libBar) {
		t.Errorf("libFoo missing dependency on afdo variant of libBar")
		}

		fooVariants := result.ModuleVariantsForTests("foo")
		for _, v := range fooVariants {
		if strings.Contains(v, "afdo-") {
		t.Errorf("Expected no afdo variant of 'foo', got %q", v)
		}
		}

		cFlags := libFoo.Rule("cc").Args["cFlags"]
		if w := "-fprofile-sample-accurate"; strings.Contains(cFlags, w) {
		t.Errorf("Expected 'foo' to not enable afdo, but found %q in cflags %q", w, cFlags)
		}

		barVariants := result.ModuleVariantsForTests("bar")
		for _, v := range barVariants {
		if strings.Contains(v, "afdo-") {
		t.Errorf("Expected no afdo variant of 'bar', got %q", v)
		}
		}

		}