Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b85d81a authored by Hsin-Yi Chen's avatar Hsin-Yi Chen
Browse files

Add product name to the opt-in ABI error message 

Normally, the users of opt-in ABI check do not enable it for all
architectures. The error message instructs the users to update the ABI
reference dumps for the product failing on the check.

Test: make
Bug: 254141417
Change-Id: I19d28c83a3485266a190ba8abc9ddfb8deeb5106
parent 8ee97f7a

cc/library.go

+4 −0
Original line number Diff line number Diff line
@@ -1963,6 +1963,10 @@ func (library *libraryDecorator) optInAbiDiff(ctx android.ModuleContext, referen 


	libName := strings.TrimSuffix(baseName, filepath.Ext(baseName))

	errorMessage := "error: Please update ABI references with: $$ANDROID_BUILD_TOP/development/vndk/tools/header-checker/utils/create_reference_dumps.py -l " + libName + " -ref-dump-dir $$ANDROID_BUILD_TOP/" + refDumpDir

	// Most opt-in libraries do not have dumps for all default architectures.

	if ctx.Config().HasDeviceProduct() {

		errorMessage += " -products " + ctx.Config().DeviceProduct()

	}



	library.sourceAbiDiff(ctx, referenceDump, baseName, nameExt,

		isLlndkOrNdk, false /* allowExtensions */, "current", errorMessage)