Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82126214 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Reduce default global google-* clang-tidy checks 

Now only keep the ones that do not have thousands of warnings.
We can add more such checks locally or when more warnings
are fixed or suppressed in source files.

Bug: 112478838
Bug: 218759304
Test: make tidy-soong_subset
Change-Id: Iac93310441cdc64ed80e8c30159a08f95e1e9ebc
parent 53c6c67c

cc/config/tidy.go

+15 −10
Original line number Diff line number Diff line
@@ -35,14 +35,22 @@ func init() { 
			"bugprone-*",

			"cert-*",

			"clang-diagnostic-unused-command-line-argument",

			"google-*",

			// Select only google-* checks that do not have thousands of warnings.

			// Add more such checks when we clean up source code.

			// "google-build-using-namespace",

			// "google-default-arguments",

			// "google-explicit-constructor",

			// "google-global-names-in-headers",

			// "google-runtime-int",

			"google-build-explicit-make-pair",

			"google-build-namespaces",

			"google-runtime-operator",

			"google-upgrade-*",

			"misc-*",

			"performance-*",

			"portability-*",

			"-bugprone-easily-swappable-parameters",

			"-bugprone-narrowing-conversions",

			"-google-readability*",

			"-google-runtime-references",

			"-misc-no-recursion",

			"-misc-non-private-member-variables-in-classes",

			"-misc-unused-parameters",
@@ -79,13 +87,10 @@ func init() { 
		return strings.Join([]string{

			"-*",

			"clang-diagnostic-unused-command-line-argument",

			"google*",

			"-google-build-using-namespace",

			"-google-default-arguments",

			"-google-explicit-constructor",

			"-google-readability*",

			"-google-runtime-int",

			"-google-runtime-references",

			"google-build-explicit-make-pair",

			"google-build-namespaces",

			"google-runtime-operator",

			"google-upgrade-*",

		}, ",")

	})