Commit 7e7ef560 authored Nov 25, 2020 by Ulf Adams

Soong: remove output file before running signapk

It looks like there is a bug in rewrapper/reproxy that makes it upload the
output file as an input if it still exists in the output tree. This causes
unnecessary cache misses on incremental builds, and can also cause the
action to fail remotely (depending on the service). By removing the output
file at the beginning of the action, we ensure that it can't be uploaded.

Test: ran against a remote execution server; actions no longer fail remotely
Change-Id: Iaac2b23b35d2c876c0244edbfd4a8f159df0563c

parent 0066864a

java/app_builder.go

+1 −1

Original line number	Diff line number	Diff line
		@@ -32,7 +32,7 @@ import (
		var (
		Signapk, SignapkRE = remoteexec.StaticRules(pctx, "signapk",
		blueprint.RuleParams{
		Command: `$reTemplate${config.JavaCmd} ${config.JavaVmFlags} -Djava.library.path=$$(dirname ${config.SignapkJniLibrary}) ` +
		Command: `rm -f $out && $reTemplate${config.JavaCmd} ${config.JavaVmFlags} -Djava.library.path=$$(dirname ${config.SignapkJniLibrary}) ` +
		`-jar ${config.SignapkCmd} $flags $certificates $in $out`,
		CommandDeps: []string{"${config.SignapkCmd}", "${config.SignapkJniLibrary}"},
		},