Commit 79b9b94e authored May 12, 2023 by Yi Kong Committed by Cherrypicker Worker May 18, 2023

Revert "Turn off stack protector check for noreturn calls"

clang-r487747c contains upstream fix for the excessive stack protactor
checks (fc4494dffa54) and checks are no longer inserted for C only code
or C++ code built without exeception. The Android platform does not
enable C++ exception by default, thus turning on the check should not
have significant performance impact.

This reverts commit ecc18df6.

Test: presubmit
Bug: 277565884
Bug: 279955553
(cherry picked from https://android-review.googlesource.com/q/commit:e9850f81531f070ac5cd193fdcd767bc91605bfe)
Merged-In: I2fc5826048ba5d00cabcc8401ac40a6f54812a44
Change-Id: I2fc5826048ba5d00cabcc8401ac40a6f54812a44

parent 4020b810

cc/config/global.go

+0 −6

Original line number	Diff line number	Diff line
		@@ -111,9 +111,6 @@ var (

		// Turn off FMA which got enabled by default in clang-r445002 (http://b/218805949)
		"-ffp-contract=off",

		// Turn off stack protector check for noreturn calls. (http://b/264965700)
		"-mllvm -disable-check-noreturn-call",
		}

		commonGlobalConlyflags = []string{}
		@@ -150,9 +147,6 @@ var (
		commonGlobalLldflags = []string{
		"-fuse-ld=lld",
		"-Wl,--icf=safe",

		// Turn off stack protector check for noreturn calls. (http://b/264965700)
		"-Wl,-mllvm,-disable-check-noreturn-call",
		}

		deviceGlobalCppflags = []string{