Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78425e51 authored by Krzysztof Kosiński's avatar Krzysztof Kosiński
Browse files

Allow enabling -Wreorder-init-list from Android.bp. 

I want to make this warning an error in my project and the
current setup is preventing me from doing so.

This has to be -Wno-error=reorder-init-list and not
-Wno-reorder-init-list because the later is overridden by some
modules explicitly enabling warning sets. -Wno-* flags are
overridden by -W* flags coming later in the command line,
but -Wno-error=* flags are only overridden by later -Werror=
flags.

Bug: 145210666
Test: presubmit
Change-Id: Ia08f8a20da37cdc57167324b0cd19413d8786990
parent 43157967

cc/config/global.go

+3 −2
Original line number Diff line number Diff line
@@ -101,6 +101,9 @@ var ( 
		// Warnings from clang-12

		"-Wno-gnu-folding-constant",



		// http://b/145210666

		"-Wno-error=reorder-init-list",



		// Calls to the APIs that are newer than the min sdk version of the caller should be

		// guarded with __builtin_available.

		"-Wunguarded-availability",
@@ -218,8 +221,6 @@ var ( 
		// new warnings are fixed.

		"-Wno-tautological-constant-compare",

		"-Wno-tautological-type-limit-compare",

		// http://b/145210666

		"-Wno-reorder-init-list",

		// http://b/145211066

		"-Wno-implicit-int-float-conversion",

		// New warnings to be fixed after clang-r377782.