Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c5b8f4e authored by Ivan Lozano's avatar Ivan Lozano
Browse files

rust: Skip global 'fuzzer' sanitizer static bins 

The 'fuzzer' sanitizer enables 'hwasan', which is not supported for Rust
static binaries. Make sure we skip applying this sanitizer to those
binaries.

Bug: 204776996
Test: SANITIZE_TARGET=fuzzer m <static_rust_executable>
Change-Id: I619cfab32b46c0811590973344eb5cdbe3f1a119
parent 52a3e36c

rust/sanitize.go

+6 −3
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ func (sanitize *sanitize) begin(ctx BaseModuleContext) { 


		// Global Sanitizers

		if found, globalSanitizers = android.RemoveFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {

			// TODO(b/180495975): HWASan for static Rust binaries isn't supported yet.

			// TODO(b/204776996): HWASan for static Rust binaries isn't supported yet.

			if !ctx.RustModule().StaticExecutable() {

				s.Hwaddress = proptools.BoolPtr(true)

			}
@@ -161,8 +161,11 @@ func (sanitize *sanitize) begin(ctx BaseModuleContext) { 
		}



		if found, globalSanitizers = android.RemoveFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {

			// TODO(b/204776996): HWASan for static Rust binaries isn't supported yet, and fuzzer enables HWAsan

			if !ctx.RustModule().StaticExecutable() {

				s.Fuzzer = proptools.BoolPtr(true)

			}

		}



		// Global Diag Sanitizers

		if found, globalSanitizersDiag = android.RemoveFromList("memtag_heap", globalSanitizersDiag); found &&
@@ -289,7 +292,7 @@ func rustSanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) { 
			deps = []string{config.LibclangRuntimeLibrary(mod.toolchain(mctx), "asan")}

		} else if mod.IsSanitizerEnabled(cc.Hwasan) ||

			(mod.IsSanitizerEnabled(cc.Fuzzer) && mctx.Arch().ArchType == android.Arm64) {

			// TODO(b/180495975): HWASan for static Rust binaries isn't supported yet.

			// TODO(b/204776996): HWASan for static Rust binaries isn't supported yet.

			if binary, ok := mod.compiler.(binaryInterface); ok {

				if binary.staticallyLinked() {

					mctx.ModuleErrorf("HWASan is not supported for static Rust executables yet.")