Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fe637aa authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

no out/soong/... in default header-filter 

* There are too many warnings from out/.../*.pb.h
  and other generated header files.

Bug: 180862582
Bug: 231245501
Test: WITH_TIDY=1 make
Change-Id: Ibabc1040666b50c6dec4fd66ae999a3441324fbd
parent 8b9c23ec

cc/tidy.go

+7 −2
Original line number Diff line number Diff line
@@ -96,10 +96,15 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags { 
	if !android.SubstringInList(flags.TidyFlags, "-header-filter=") {

		defaultDirs := ctx.Config().Getenv("DEFAULT_TIDY_HEADER_DIRS")

		headerFilter := "-header-filter="

		// Default header filter should include only the module directory,

		// not the out/soong/.../ModuleDir/...

		// Otherwise, there will be too many warnings from generated files in out/...

		// If a module wants to see warnings in the generated source files,

		// it should specify its own -header-filter flag.

		if defaultDirs == "" {

			headerFilter += ctx.ModuleDir() + "/"

			headerFilter += "^" + ctx.ModuleDir() + "/"

		} else {

			headerFilter += "\"(" + ctx.ModuleDir() + "/|" + defaultDirs + ")\""

			headerFilter += "\"(^" + ctx.ModuleDir() + "/|" + defaultDirs + ")\""

		}

		flags.TidyFlags = append(flags.TidyFlags, headerFilter)

	}