Move genrule tests to genrule_conversion_test.go. am: c5fa306162 (545ed91f) · Commits · e / os / android_build_soong

bp2build/Android.bp

+1 −0

Original line number	Diff line number	Diff line
		@@ -40,6 +40,7 @@ bootstrap_go_package {
		"cc_object_conversion_test.go",
		"conversion_test.go",
		"filegroup_conversion_test.go",
		"genrule_conversion_test.go",
		"performance_test.go",
		"prebuilt_etc_conversion_test.go",
		"python_binary_conversion_test.go",

bp2build/build_conversion_test.go

+0 −403

Original line number	Diff line number	Diff line
		@@ -16,7 +16,6 @@ package bp2build

		import (
		"android/soong/android"
		"android/soong/genrule"
		"strings"
		"testing"
		)
		@@ -529,21 +528,6 @@ load("//build/bazel/rules:rules.bzl", "my_library")`,
		}

		func TestModuleTypeBp2Build(t *testing.T) {
		otherGenruleBp := map[string]string{
		"other/Android.bp": `genrule {
		name: "foo.tool",
		out: ["foo_tool.out"],
		srcs: ["foo_tool.in"],
		cmd: "cp $(in) $(out)",
		}
		genrule {
		name: "other.tool",
		out: ["other_tool.out"],
		srcs: ["other_tool.in"],
		cmd: "cp $(in) $(out)",
		}`,
		}

		testCases := []bp2buildTestCase{
		{
		description: "filegroup with does not specify srcs",
		@@ -698,200 +682,6 @@ genrule {
		}`,
		},
		},
		{
		description: "genrule with command line variable replacements",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo.tool",
		out: ["foo_tool.out"],
		srcs: ["foo_tool.in"],
		cmd: "cp $(in) $(out)",
		bazel_module: { bp2build_available: true },
		}

		genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		tools: [":foo.tool"],
		cmd: "$(location :foo.tool) --genDir=$(genDir) arg $(in) $(out)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{
		`genrule(
		name = "foo",
		cmd = "$(location :foo.tool) --genDir=$(GENDIR) arg $(SRCS) $(OUTS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		tools = [":foo.tool"],
		)`,
		`genrule(
		name = "foo.tool",
		cmd = "cp $(SRCS) $(OUTS)",
		outs = ["foo_tool.out"],
		srcs = ["foo_tool.in"],
		)`,
		},
		},
		{
		description: "genrule using $(locations :label)",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo.tools",
		out: ["foo_tool.out", "foo_tool2.out"],
		srcs: ["foo_tool.in"],
		cmd: "cp $(in) $(out)",
		bazel_module: { bp2build_available: true },
		}

		genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		tools: [":foo.tools"],
		cmd: "$(locations :foo.tools) -s $(out) $(in)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "$(locations :foo.tools) -s $(OUTS) $(SRCS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		tools = [":foo.tools"],
		)`,
		`genrule(
		name = "foo.tools",
		cmd = "cp $(SRCS) $(OUTS)",
		outs = [
		"foo_tool.out",
		"foo_tool2.out",
		],
		srcs = ["foo_tool.in"],
		)`,
		},
		},
		{
		description: "genrule using $(locations //absolute:label)",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		tool_files: [":foo.tool"],
		cmd: "$(locations :foo.tool) -s $(out) $(in)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "$(locations //other:foo.tool) -s $(OUTS) $(SRCS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		tools = ["//other:foo.tool"],
		)`,
		},
		filesystem: otherGenruleBp,
		},
		{
		description: "genrule srcs using $(locations //absolute:label)",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: [":other.tool"],
		tool_files: [":foo.tool"],
		cmd: "$(locations :foo.tool) -s $(out) $(location :other.tool)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "$(locations //other:foo.tool) -s $(OUTS) $(location //other:other.tool)",
		outs = ["foo.out"],
		srcs = ["//other:other.tool"],
		tools = ["//other:foo.tool"],
		)`,
		},
		filesystem: otherGenruleBp,
		},
		{
		description: "genrule using $(location) label should substitute first tool label automatically",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		tool_files: [":foo.tool", ":other.tool"],
		cmd: "$(location) -s $(out) $(in)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "$(location //other:foo.tool) -s $(OUTS) $(SRCS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		tools = [
		"//other:foo.tool",
		"//other:other.tool",
		],
		)`,
		},
		filesystem: otherGenruleBp,
		},
		{
		description: "genrule using $(locations) label should substitute first tool label automatically",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		tools: [":foo.tool", ":other.tool"],
		cmd: "$(locations) -s $(out) $(in)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "$(locations //other:foo.tool) -s $(OUTS) $(SRCS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		tools = [
		"//other:foo.tool",
		"//other:other.tool",
		],
		)`,
		},
		filesystem: otherGenruleBp,
		},
		{
		description: "genrule without tools or tool_files can convert successfully",
		moduleTypeUnderTest: "genrule",
		moduleTypeUnderTestFactory: genrule.GenRuleFactory,
		moduleTypeUnderTestBp2BuildMutator: genrule.GenruleBp2Build,
		blueprint: `genrule {
		name: "foo",
		out: ["foo.out"],
		srcs: ["foo.in"],
		cmd: "cp $(in) $(out)",
		bazel_module: { bp2build_available: true },
		}`,
		expectedBazelTargets: []string{`genrule(
		name = "foo",
		cmd = "cp $(SRCS) $(OUTS)",
		outs = ["foo.out"],
		srcs = ["foo.in"],
		)`,
		},
		},
		}

		dir := "."
		@@ -947,199 +737,6 @@ genrule {

		type bp2buildMutator = func(android.TopDownMutatorContext)

		func TestBp2BuildInlinesDefaults(t *testing.T) {
		testCases := []struct {
		moduleTypesUnderTest map[string]android.ModuleFactory
		bp2buildMutatorsUnderTest map[string]bp2buildMutator
		bp string
		expectedBazelTarget string
		description string
		}{
		{
		moduleTypesUnderTest: map[string]android.ModuleFactory{
		"genrule": genrule.GenRuleFactory,
		"genrule_defaults": func() android.Module { return genrule.DefaultsFactory() },
		},
		bp2buildMutatorsUnderTest: map[string]bp2buildMutator{
		"genrule": genrule.GenruleBp2Build,
		},
		bp: `genrule_defaults {
		name: "gen_defaults",
		cmd: "do-something $(in) $(out)",
		}
		genrule {
		name: "gen",
		out: ["out"],
		srcs: ["in1"],
		defaults: ["gen_defaults"],
		bazel_module: { bp2build_available: true },
		}
		`,
		expectedBazelTarget: `genrule(
		name = "gen",
		cmd = "do-something $(SRCS) $(OUTS)",
		outs = ["out"],
		srcs = ["in1"],
		)`,
		description: "genrule applies properties from a genrule_defaults dependency if not specified",
		},
		{
		moduleTypesUnderTest: map[string]android.ModuleFactory{
		"genrule": genrule.GenRuleFactory,
		"genrule_defaults": func() android.Module { return genrule.DefaultsFactory() },
		},
		bp2buildMutatorsUnderTest: map[string]bp2buildMutator{
		"genrule": genrule.GenruleBp2Build,
		},
		bp: `genrule_defaults {
		name: "gen_defaults",
		out: ["out-from-defaults"],
		srcs: ["in-from-defaults"],
		cmd: "cmd-from-defaults",
		}
		genrule {
		name: "gen",
		out: ["out"],
		srcs: ["in1"],
		defaults: ["gen_defaults"],
		cmd: "do-something $(in) $(out)",
		bazel_module: { bp2build_available: true },
		}
		`,
		expectedBazelTarget: `genrule(
		name = "gen",
		cmd = "do-something $(SRCS) $(OUTS)",
		outs = [
		"out-from-defaults",
		"out",
		],
		srcs = [
		"in-from-defaults",
		"in1",
		],
		)`,
		description: "genrule does merges properties from a genrule_defaults dependency, latest-first",
		},
		{
		moduleTypesUnderTest: map[string]android.ModuleFactory{
		"genrule": genrule.GenRuleFactory,
		"genrule_defaults": func() android.Module { return genrule.DefaultsFactory() },
		},
		bp2buildMutatorsUnderTest: map[string]bp2buildMutator{
		"genrule": genrule.GenruleBp2Build,
		},
		bp: `genrule_defaults {
		name: "gen_defaults1",
		cmd: "cp $(in) $(out)",
		}

		genrule_defaults {
		name: "gen_defaults2",
		srcs: ["in1"],
		}

		genrule {
		name: "gen",
		out: ["out"],
		defaults: ["gen_defaults1", "gen_defaults2"],
		bazel_module: { bp2build_available: true },
		}
		`,
		expectedBazelTarget: `genrule(
		name = "gen",
		cmd = "cp $(SRCS) $(OUTS)",
		outs = ["out"],
		srcs = ["in1"],
		)`,
		description: "genrule applies properties from list of genrule_defaults",
		},
		{
		moduleTypesUnderTest: map[string]android.ModuleFactory{
		"genrule": genrule.GenRuleFactory,
		"genrule_defaults": func() android.Module { return genrule.DefaultsFactory() },
		},
		bp2buildMutatorsUnderTest: map[string]bp2buildMutator{
		"genrule": genrule.GenruleBp2Build,
		},
		bp: `genrule_defaults {
		name: "gen_defaults1",
		defaults: ["gen_defaults2"],
		cmd: "cmd1 $(in) $(out)", // overrides gen_defaults2's cmd property value.
		}

		genrule_defaults {
		name: "gen_defaults2",
		defaults: ["gen_defaults3"],
		cmd: "cmd2 $(in) $(out)",
		out: ["out-from-2"],
		srcs: ["in1"],
		}

		genrule_defaults {
		name: "gen_defaults3",
		out: ["out-from-3"],
		srcs: ["srcs-from-3"],
		}

		genrule {
		name: "gen",
		out: ["out"],
		defaults: ["gen_defaults1"],
		bazel_module: { bp2build_available: true },
		}
		`,
		expectedBazelTarget: `genrule(
		name = "gen",
		cmd = "cmd1 $(SRCS) $(OUTS)",
		outs = [
		"out-from-3",
		"out-from-2",
		"out",
		],
		srcs = [
		"srcs-from-3",
		"in1",
		],
		)`,
		description: "genrule applies properties from genrule_defaults transitively",
		},
		}

		dir := "."
		for _, testCase := range testCases {
		config := android.TestConfig(buildDir, nil, testCase.bp, nil)
		ctx := android.NewTestContext(config)
		for m, factory := range testCase.moduleTypesUnderTest {
		ctx.RegisterModuleType(m, factory)
		}
		for mutator, f := range testCase.bp2buildMutatorsUnderTest {
		ctx.RegisterBp2BuildMutator(mutator, f)
		}
		ctx.RegisterForBazelConversion()

		_, errs := ctx.ParseFileList(dir, []string{"Android.bp"})
		android.FailIfErrored(t, errs)
		_, errs = ctx.ResolveDependencies(config)
		android.FailIfErrored(t, errs)

		codegenCtx := NewCodegenContext(config, *ctx.Context, Bp2Build)
		bazelTargets := generateBazelTargetsForDir(codegenCtx, dir)
		if actualCount := len(bazelTargets); actualCount != 1 {
		t.Fatalf("%s: Expected 1 bazel target, got %d", testCase.description, actualCount)
		}

		actualBazelTarget := bazelTargets[0]
		if actualBazelTarget.content != testCase.expectedBazelTarget {
		t.Errorf(
		"%s: Expected generated Bazel target to be '%s', got '%s'",
		testCase.description,
		testCase.expectedBazelTarget,
		actualBazelTarget.content,
		)
		}
		}
		}

		func TestAllowlistingBp2buildTargetsExplicitly(t *testing.T) {
		testCases := []struct {
		moduleTypeUnderTest string

bp2build/genrule_conversion_test.go

0 → 100644

+479 −0

File added.

Preview size limit exceeded, changes collapsed.