Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e31fb87 authored by Nick Desaulniers's avatar Nick Desaulniers
Browse files

soong: move -Wimplicit-fallthrough from cflags to cxxflags 



The compiler upgrade to r370808 can now check C code for implicit
fallthrough. This is triggering a massive number of warnings throughout
external/ and the rest of the platform.

Revisit enabling this for C another day.

Bug: 139945549
Test: m
Change-Id: I8dfaedab78c6230b46e8a45a9e65106dec363380
Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
parent d0e39622

cc/config/clang.go

+3 −3
Original line number Diff line number Diff line
@@ -101,9 +101,6 @@ func init() { 
		// not emit the table by default on Android since NDK still uses GNU binutils.

		"-faddrsig",



		// -Wimplicit-fallthrough is not enabled by -Wall.

		"-Wimplicit-fallthrough",



		// Help catch common 32/64-bit errors.

		"-Werror=int-conversion",
@@ -138,6 +135,9 @@ func init() { 
	}, " "))



	pctx.StaticVariable("ClangExtraCppflags", strings.Join([]string{

		// -Wimplicit-fallthrough is not enabled by -Wall.

		"-Wimplicit-fallthrough",



		// Enable clang's thread-safety annotations in libcxx.

		// Turn off -Wthread-safety-negative, to avoid breaking projects that use -Weverything.

		"-D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS",